1582375 - Urlbar should be focused when clicking its search icon

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Comment 1

[Shane Hughes [:aminomancer]]

the urlbar is focused when clicking the search icon. but initiating input and opening the urlbar results popup is not triggered by focusing the urlbar, it's triggered by focusing the urlbar input container, which is to the right of the search icon, which is really an identity icon. to change that you'd have to deal with some inconsistencies. the identity icon, tracking protection icon, and other icons (notifications, permissions, etc.) have their own click events already. the search icon is the only exception but it's not its own icon, it is just the identity icon with pointer-events: none. one way to make this happen would be to give the search icon its own unique object and make it a child of urlbar-input-container. then urlbar input container would cover the whole left side of the urlbar when [pageproxystate="invalid"], and that region would be available to register click events.

but this would be sort of inconsistent behavior, don't you think? it might be confusing to users that sometimes, they can click the icons to the left of the url to start typing a search/url, but other times, clicking those icons will only open their corresponding popups. also, the behavior of the icons would then be changing all the time. when you first load a page, [pageproxystate="valid"] and you see a lock icon and a tracking icon. but when you type into the urlbar, it becomes invalid and those icons disappear and would then be replaced by the search icon, which you could click to open the urlbar. so you might click the icon and type a url, and hit enter. and then when the page loads you might click the icon again to repeat the process, but now you can't, because pageproxystate has returned to valid and the search icon has been replaced with the identity icon.

it's a bit of a compromise but imo those icon popups are more valuable than the click behavior of the search icon. especially now with identity labels being hidden, the way for average users to get detailed information about the security of a page is to click the identity icon and the tracking protection icon. that will give them information the icons cannot convey pictorially, like permissions, the certificate, which elements are insecure, which trackers or malicious scripts have been detected, etc. there might be a better compromise that i haven't thought of though.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1582375 - Focus the urlbar when clicking directly on the input container (this includes the search glass which doesn't consume pointer events). r=harry

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65f2f41ae481
Focus the urlbar when clicking directly on the input container (this includes the search glass which doesn't consume pointer events). r=harry

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/65f2f41ae481

Comment 5

[Md. Majedul islam]

I have reproduced this bug with Nightly 71.0a1 (2019-09-19) on windows 10, 64 bit!

The fix is now verified on Latest Nightly 71.0a1

Build ID : 20190930095343
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Comment 7

[Cristian Fogel [:cfogel]]

Adding :ccomorasu for bug verification