1582564 - Tweaks for the minimonth and calendar view with dark theme

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Richard Marti (:Paenglab)]

Issues from bug 1579411

• The labels for the time row in the calendar view are hard to read. Maybe make them brighter like the column labels?
• The days in mini-month have border around them. I do not like that. Maybe make them border-less like in Light mode?
• The week number in mini-month looks same as day label. Maybe make them more distinguishable from each other, like in Light mode?

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1582564-calendar-theme-tweaks.patch

This should fix the three issues.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1582564-calendar-theme-tweaks-ESR.patch

Patch for ESR.

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9094017 [details] [diff] [review]
1582564-calendar-theme-tweaks.patch

Review of attachment 9094017 [details] [diff] [review]:
-----------------------------------------------------------------

Looks nice!  (And quick turn-around.)  r+

Comment 4

[Jorg K (CEST = GMT+2)]

So how do you spell/write the name of that widget? MiniMonth, mini-month, minimonth or Minimonth? The commit message of bug 1579411 had MiniMonth, and apparently the documentation does as well:
https://searchfox.org/comm-central/rev/a0d8cebe03edfd7eb8066991c8e6382cf5184b7b/calendar/base/content/widgets/calendar-minimonth.js#14

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/41d027b50834
Tweaks for the MiniMonth and calendar view with dark theme. r=pmorris DONTBUILD

Comment 6

[Richard Marti (:Paenglab)]

MiniMonth is okay. I used minimonth probably because of the minimonth.css (or my shift key finger is sometimes not fast enough to press together with the other key).

Comment 7

[Jorg K (CEST = GMT+2)]

TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/8784f8a4d8588d63bd632325b4471506b3659768

Comment 8

[Stefan Sitter [:ssitter]]

Attachment: today-pane-mini-month.png

Thanks Paenglab, looking much better now.

But when I increase width of today pane the mini-month has light background color. The mini-month in the left pane doesn't have this problem.

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.1.1 ESR / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/d1af9cdfdcd59558127b3e26113ff367e56f1aae