1582716 - Remove nsDocShell::GetIsOnlyToplevelInTabGroup

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Description

[Andreas Farre [:farre] (PTO -> Aug 1st)]

We're trying to remove TabGroup, and with BrowsingContext we can compute if a browsing context is the only top level browsing context (auxiliary or otherwise).

Comment 1

[Andreas Farre [:farre] (PTO -> Aug 1st)]

Nika, do you know which tests that would exercise Large-Allocation? It's the only thing affected by this.

Comment 2

[Andreas Farre [:farre] (PTO -> Aug 1st)]

Attachment: Bug 1582716 - Remove nsDocShell::GetIsOnlyToplevelInTabGroup. r=nika

We can remove isOnlyToplevelInTabGroup entirely since we have
BrowsingContext/BrowsingContextGroup exposed through
chrome-webidl. Checking if a browsing context is the only top level
(auxilliary or otherwise) is only a matter of checking that there
isn't a parent, and that the size of the browsing context group is 1.

Comment 3

[Nika Layzell [:nika] (ooo, ni? for response)]

The following are all of the tests for it. Don't worry about the _win32 one, as it's effectively the _non_win32 one except without the force-enable pref, and only run on 32-bit windows.

largeAllocation is also probably super broken with fission enabled. It will need to be rewritten for fission at some point.

• https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/dom/tests/browser/browser_allocateGigabyte.js
• https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/dom/tests/browser/browser_largeAllocation_non_win32.js
• https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/dom/tests/browser/browser_largeAllocation_win32.js
• https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/dom/security/test/csp/test_reloadInFreshProcess.html
• https://searchfox.org/mozilla-central/rev/7531325c8660cfa61bf71725f83501028178cbb9/dom/tests/browser/test_largeAllocation.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db132849d960
Remove nsDocShell::GetIsOnlyToplevelInTabGroup. r=nika

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/470b29c571d7
Backed out changeset db132849d960 for causing linting failures in /builds/worker/checkouts/gecko/toolkit/modules/E10SUtils.jsm CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5aa3ac4483e
Remove nsDocShell::GetIsOnlyToplevelInTabGroup. r=nika

Comment 7

[Cristian Brindusan [:cbrindusan]]

I had to backout this due to related file used in Bug 1575051.

Backout: https://hg.mozilla.org/integration/autoland/rev/da9b99b612612970527222d0285ed4f729b5e0e4

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:farre, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/894d4b90c37e
Remove nsDocShell::GetIsOnlyToplevelInTabGroup. r=nika

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/894d4b90c37e