1561715 - Remove `TabGroup` in favour of `BrowsingContextGroup`

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P1)

Description

[Nika Layzell [:nika] (ni? for response)]

These two concepts should now reflect the same idea in the in-process case, but BrowsingContextGroup now correctly exists and works across processes. At some point, we should completely rip out TabGroup, and replace it with BrowsingContextGroup to avoid having different concepts here, and make the concept more fission future-proof.

Comment 1

[Chris Peterson [:cpeterson]]

Roll some unfixed bugs from Fission Milestone M4 to M6

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Chris Peterson [:cpeterson]]

Test bug 1588926 in milestone M4.1 depends on this bug, so I am tentatively moving this bug to M4.1 too.

Comment 3

[Neha Kochar [:neha]]

The M4.1 test which was blocked on this is now resolved. This now blocks the M5 crashes, so moving this to M5 too.

Comment 4

[Andreas Farre [:farre]]

Attachment: Bug 1561715 - Part 1: Remove unused functionality in SchedulerGroup. r=smaug,froydnj

Comment 5

[Andreas Farre [:farre]]

Attachment: Bug 1561715 - Part 2: Remove TabGroup::Count. r=smaug

Comment 6

[Andreas Farre [:farre]]

Attachment: Bug 1561715 - Part 3: Remove SchedulerGroup::IsBackground. r=smaug

Depends on D56745

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c201d1f7c1a8
Part 1: Remove unused functionality in SchedulerGroup. r=smaug

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c201d1f7c1a8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/529292d8e921
Part 2: Remove TabGroup::Count. r=smaug

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/529292d8e921

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57904839c037
Part 3: Remove SchedulerGroup::IsBackground. r=smaug

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/57904839c037

Comment 13

[Chris Peterson [:cpeterson]]

Andreas, are you still working on removing TabGroups for our Fission M5 dogfooding milestone?

Comment 14

[Andreas Farre [:farre]]

Chris: yes, occasionally now and again.

Comment 15

[Andreas Farre [:farre]]

I decided to finish this in bug 1620594 to not have to trouble with the existing incremental patches in this bug. I'll close this as soon as bug 1620594 is resolved.

Comment 16

[Chris Peterson [:cpeterson]]

Moving P1 M5 bugs to M5a milestone

Comment 17

[Chris Peterson [:cpeterson]]

Moving to Fission M5b because this fix is important but not top priority.

Comment 18

[Chris Peterson [:cpeterson]]

depends on completely removing TabGroup in bug 1620594

Comment 19

[Andreas Farre [:farre]]

Bug 1620594 has been fixed, and by that this bug is ready to be closed!