1582746 - After quick fix of bug 1582429 the TB stopped to sync WCAP calendar

Status: RESOLVED FIXED

(Calendar :: Provider: WCAP, defect)

Description

[Victor]

Attachment: TBerrors1.txt

User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

Configured WCAP calendar and TB does not sync it

Actual results:

Newly created calendar has exclamation mark in triangle next to its name now.

Expected results:

I expect calendar will be synced with the calendar server

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks, plenty of errors in that log. This won't be as quick to fix as the other bug.

Comment 2

[John Bieling (:TbSync)]

Does anyone know if WCAP requires cookies to work? There is an issue with TB68, which does not allow us to use cookies in network requests. Lightning CalDAV also is not able to use cookies at the moment (it ignores Set-Cookie headers). Could that be related?

Comment 3

[Victor]

Well, according to this https://en.wikipedia.org/wiki/Web_Calendar_Access_Protocol WCAP uses cookies
In the Response example there is Set-Cookie in the header:
HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
X-Powered-By: Servlet 2.4; JBoss-4.0.4.GA (build: CVSTag=JBoss_4_0_4_GA date=200605151000)/Tomcat-5.5
Set-Cookie: JSESSIONID=41DAC48C79927D68EDFAF5FBFD491236; Path=/
Content-Type: text/html;charset=ISO-8859-1
Content-Length: 1399
Date: Mon, 21 May 2007 19:43:37 GMT

However I cannot find anything about cookies in Oracle Communications Calendar Server WCAP Developer's Guide Release 7.0
https://docs.oracle.com/cd/E54932_01/doc.705/e56603/cs_wcap_commands.htm#CSVDV169

Comment 4

[Jorg K (CEST = GMT+2)]

Geoff, can we do anything here in a hurry. Do we have a WCAP server to test?

Comment 5

[Victor]

Hello gents,

TB 68.1.1 is out and it allows to add new WCAP calendar without errors which were in 68.1.0.
I confirm the bug 1582429 is fixed in 68.1.1 but probably you know that better then me.

Is there any progress with the current bug?
Does the test account on WCAP server help to understand why WCAP calendar does not sync it with the server?
v.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

We're moving the WCAP Provider out of the tree, therefore unfortunately we won't be providing further support. If you'd like to get involved in the development of the WCAP Provider please contact me via email.

Comment 7

[Jorg K (CEST = GMT+2)]

WCAP is removed as well as gData? That's news to me.

Comment 8

[Magnus Melin [:mkmelin]]

Not yet but soon. Bug 1579020

Comment 9

[John Bieling (:TbSync)]

Couldn't you have said that earlier? I spend multiple hours investigating this!

You really want to remove it from TB68?

Comment 10

[Magnus Melin [:mkmelin]]

Removal would be for trunk I think.

Comment 11

[John Bieling (:TbSync)]

The reason for this issue is this line:

https://searchfox.org/comm-central/source/calendar/providers/wcap/calWcapRequest.js#272

it must be changed to

this.execRespFunc(aStatus, result);

Comment 12

[Jorg K (CEST = GMT+2)]

Great. Can you provide a patch and get Geoff or Paul to review and approve it for ESR 68. Or let me do it. Note that WCAP is being removed soon in bug 1579020, but we might as well fix it for ESR so it runs for another year.

Comment 13

[John Bieling (:TbSync)]

Attachment: {e2fda1a4-762b-4020-b5ad-a41df1933103}.zip

Fixed version of Lightning.

Comment 14

[John Bieling (:TbSync)]

Victor, can you verify, that the attached version of lightning is working?

Please follow the instructions from Jorg (https://bugzilla.mozilla.org/show_bug.cgi?id=1582429#c27) to make sure that the new version is really loaded.

@Jorg: I currently do not have a build system up and cannot provide a real patch. As we will fix this only for TB68, can we slip it in trought the backdoor? Or do we need to go trunk -> approve beta -> approve esr?

Comment 15

[Jorg K (CEST = GMT+2)]

Broken here:
https://hg.mozilla.org/comm-central/rev/465c90ec3466efeac4e52f3696d889069f23ca2a#l2.78

Comment 16

[Jorg K (CEST = GMT+2)]

Attachment: 1584795.patch

This is John's patch in his name.

Comment 17

[Jorg K (CEST = GMT+2)]

Attachment: 1582746-wcap.patch

Wrong patch.

Comment 18

[Jorg K (CEST = GMT+2)]

Note: Untested by me and also derived from c-esr68. Should apply to trunk, but I haven't tried.

Comment 19

[Geoff Lankow (:darktrojan)]

Comment on attachment 9098191 [details] [diff] [review]
1582746-wcap.patch

I'm okay with this.

Comment 20

[Victor]

(In reply to John Bieling (TbSync) from comment #14)

Victor, can you verify, that the attached version of lightning is working?

Please follow the instructions from Jorg (https://bugzilla.mozilla.org/show_bug.cgi?id=1582429#c27) to make sure that the new version is really loaded.

@Jorg: I currently do not have a build system up and cannot provide a real patch. As we will fix this only for TB68, can we slip it in trought the backdoor? Or do we need to go trunk -> approve beta -> approve esr?

Hi,
I tried and it works!

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/437f7342a932
Fix copy/paste error from bug 1395118 to make WCAP work again. r=darktrojan

Comment 22

[Jorg K (CEST = GMT+2)]

TB 70 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/21bfb4d60f87f4150f27e7d4bf84afe802309538

Comment 23

[Jorg K (CEST = GMT+2)]

TB 68.1.2 ESR, Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/d58f8461b2ac605f4ea8810197f3c621ab663ddd

Comment 24

[Philipp Kewisch [:Fallen][📱📆]]

For the record, I've ported this patch to the github repo at https://github.com/kewisch/wcap-provider