Enable brace-style eslint rule
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: pmorris, Assigned: pmorris)
References
Details
Attachments
(2 files, 1 obsolete file)
13.67 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
1.87 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Enable the eslint brace-style rule because Prettier covers most brace formatting issues but not this one:
}
// a comment
else {
Also, enabling this rule will catch brace formatting issues in .html files, which are currently ignored by Prettier (see bug 1560186). I found some of those by enabling this rule.
Assignee | ||
Comment 1•5 years ago
•
|
||
Part 1 of 2. Manually fixes curly brace formatting in a few .html files.
As part of rolling out Prettier formatting in bug 1572047, we inserted curly brackets using eslint and then relied on Prettier to format them correctly. However, we currently tell Prettier to ignore .html files. So a few of those ended up with curly braces that were not formatted well.
(Per clokep on IRC it is not really feasible to move this JavaScript code into .js files given the way chat message styles work.)
Assignee | ||
Comment 2•5 years ago
|
||
Part 2 of 2. Enables the brace-style eslint rule for Thunderbird and removes it from the calendar .eslintrc file.
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Try server run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d068cd78264f2756ac7c5fa3c1816873b63dd7de
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Fixes bug number in commit message. Thanks for catching that Jorg.
Assignee | ||
Comment 7•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/eb003d43c655
Fix brace formatting in some .html files. r=clokep
https://hg.mozilla.org/comm-central/rev/7e7de17ddcc0
Enable 'brace-style' eslint rule. r=mkmelin
Updated•5 years ago
|
Description
•