Closed
Bug 1582870
Opened 6 years ago
Closed 6 years ago
Reduxify console actions
Categories
(DevTools :: Console, task, P1)
DevTools
Console
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(1 file)
Currently, the service container is the primary communication point for components and the context menus. It would be nice if most of the functionality lived in redux actions and actions could be the primary communication point.
The reasons for this are:
- redux actions have access to the panel, api (fronts/clients), and UI (hud, webConsoleUI)
- are more easily shared than a stateful object like service container
- more idiomatic in react apps
This proposal is a collection of ideas for starting the conversation:
- I added some redux action files (object, toolbox)
- I added a commands file for talking with the server (debuggerClient, ObjectClient, threadFront)
- I moved a bunch of functionality up into the UI and hud to de-prioritize the service container and make the thunk middleware work
- I moved the
storeAsGlobal
logic into redux so that it will be easier to fissionify it
I look forward to getting your thoughts. The mochitests should be passing, but I'm missing a bunch of context, so I'm sure things will change :)
Assignee | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Assignee: nobody → jlaster
Blocks: dt-fission-browser-console
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: dt-fission
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e433d94bc095
Reduxify console actions. r=nchevobbe
Comment 3•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•6 years ago
|
Whiteboard: dt-fission → dt-fission dt-fission-m1
Updated•4 years ago
|
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in
before you can comment on or make changes to this bug.
Description
•