1605172 - Collapsible sections JSON and Form data missing in Developer Tools Console

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[Petr Lukáš]

Attachment: 69vs71.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Check parameters in Firefox Developer Tools-Console-Param section for POST which contains JSON or Form data

Actual results:

Collapsible sections JSON and Form data with formated data in Firefox Developer Tools-Console-Param section does not show for XHR POST request.

Expected results:

There were sections JSON and Form data for display of formatted data even in Console-Params in previous versions of Firefox. Now only Request payload displayed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Sebastian Zartner [:sebo]]

I ran mozregression and it indicates that bug 1582870 caused this issue.

Sebastian

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:nchevobbe, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Would you have an example of request so I can check this please?

Comment 5

[Petr Lukáš]

For example go to: https://api.jquery.com/jQuery.post/ scroll down to "Demo" form, type a string and click to "Search" when the console is active. You can see "Request payload" section only instead of "Form data" in Console-Params. Thank you.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Thanks!

So you we can reproduce the issue with:

fetch("https://httpstat.us/200", {
  "headers": {
    "Content-Type": "application/x-www-form-urlencoded; charset=UTF-8",
  },
  "body": "s=sdfsdf",
  "method": "POST",
  "mode": "cors"
})

Netmonitor does show the "Form data" section, not the console.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1605172 - Add missing return in WebConsoleUi getLongString method. r=jlast.

The function was moved during Bug 1582870 and
we lost the return statement somehow.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24d416c773d8
Add missing return in WebConsoleUi getLongString method. r=jlast.

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/24d416c773d8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9118847 [details]
Bug 1605172 - Add missing return in WebConsoleUi getLongString method. r=jlast.

Beta/Release Uplift Approval Request

• User impact if declined: Missing section in webconsole network message panel
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open devtools and select the console

1. Make sure to have the "XHR" filter enabled
2. Evaluate the following:

fetch("/", {
  "headers": {
    "Content-Type": "application/x-www-form-urlencoded; charset=UTF-8",
  },
  "body": "s=sdfsdf",
  "method": "POST",
  "mode": "cors"
})

4. expand the message
5. select the "Params" tab
6. There should be a "Form data" section

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1-word fix (added a return in a function) in devtools
• String changes made/needed:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9118847 [details]
Bug 1605172 - Add missing return in WebConsoleUi getLongString method. r=jlast.

Approved for 73.0b3.

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/520cdcd0fc19

Comment 14

[Sebastian Zartner [:sebo]]

I can confirm that it was broken in 74.0a1 2020-01-06 and is fixed in 74.0a1 2020-01-08.
Thanks a lot for the quick fix, Nicolas!

Sebastian

Comment 15

[Cristian Baica [:cbaica], Release Desktop QA]

I have managed to reproduce the issue in Fx73.0a1(2019-12-19).
The issue is verified fixed using Fx73.0b3 and Fx74.0a1 on Windows 10, Ubuntu 18.04 and macOS 10.13. The 'Form Data' is correctly displayed.