1582929 - Event dialog: All labels for input fields disappeared from screen reader

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Jean-Philippe MENGUAL]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

1. Press ctrl-i
2. tab in the Title and Location fields

Actual results:

None of these fields are labelled, so the screen reader cannot say to the blind usr in what field he is.

Expected results:

Lightning should send to at-spi or similar the label "Title" and "Subject". This is a regression,since less than & week

Comment 1

[Stefan Sitter [:ssitter]]

Might be regressed by Bug 1569562.

Comment 2

[Magnus Melin [:mkmelin]]

See also bug 1581482.
Hmm, but the fields are now in a table. Wouldn't the screen reader say what the header of the row is?

Comment 3

[Khushil Mistry [:khushil324]]

Do we need to use label again to resolve this issue? Is there any way that html:th can be detected by the screen reader?

Comment 4

[Magnus Melin [:mkmelin]]

Probably use aria-labelledby="(id of the html:th)"

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1582929_event-dialog_input-fields-screen-reader.patch

I checked on screen-reader for accessibility on Mac.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9094538 [details] [diff] [review]
Bug-1582929_event-dialog_input-fields-screen-reader.patch

Review of attachment 9094538 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9094538 [details] [diff] [review]
Bug-1582929_event-dialog_input-fields-screen-reader.patch

Backport required here? This says "regression", but from bug 1569562 which landed during the 71 cycle. So I assume this is working in TB 70 and TB 68 ESR, right?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ed438e24de20
Fix event dialog input fields for screen reader. r=mkmelin

Comment 9

[Khushil Mistry [:khushil324]]

(In reply to Jorg K (GMT+2) from comment #7)

Backport required here? This says "regression", but from bug 1569562 which
landed during the 71 cycle. So I assume this is working in TB 70 and TB 68
ESR, right?

Yes, it's for trunk only.

Comment 10

[Jean-Philippe MENGUAL]

I confirm the bug is fixed completely. Many thanks

Best regards

Comment 11

[Jean-Philippe MENGUAL]

Just a detail: is there a non-reg test for this?

Regards

Comment 12

[Magnus Melin [:mkmelin]]

I don't think so.

Comment 13

[Jean-Philippe MENGUAL]

Should not we do one? To avoid future regression? I can run one with dogtail but I gues it would be beter to ship in Marionette?

Regards