Closed Bug 1582929 Opened 5 months ago Closed 5 months ago

Event dialog: All labels for input fields disappeared from screen reader

Categories

(Calendar :: Dialogs, defect)

Lightning 71
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jpmengual, Assigned: khushil324)

References

(Regression)

Details

(Keywords: access, regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

  1. Press ctrl-i
  2. tab in the Title and Location fields

Actual results:

None of these fields are labelled, so the screen reader cannot say to the blind usr in what field he is.

Expected results:

Lightning should send to at-spi or similar the label "Title" and "Subject". This is a regression,since less than & week

Keywords: access
Summary: All labels disappear → Event dialog: All labels for input fields disappeared from screen reader

Might be regressed by Bug 1569562.

See also bug 1581482.
Hmm, but the fields are now in a table. Wouldn't the screen reader say what the header of the row is?

Keywords: regression
Regressed by: 1569562
See Also: → 1581482
Assignee: nobody → khushil324
Status: UNCONFIRMED → NEW
Ever confirmed: true

Do we need to use label again to resolve this issue? Is there any way that html:th can be detected by the screen reader?

Probably use aria-labelledby="(id of the html:th)"

I checked on screen-reader for accessibility on Mac.

Attachment #9094538 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9094538 [details] [diff] [review]
Bug-1582929_event-dialog_input-fields-screen-reader.patch

Review of attachment 9094538 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin
Attachment #9094538 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
Comment on attachment 9094538 [details] [diff] [review]
Bug-1582929_event-dialog_input-fields-screen-reader.patch

Backport required here? This says "regression", but from bug 1569562 which landed during the 71 cycle. So I assume this is working in TB 70 and TB 68 ESR, right?

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ed438e24de20
Fix event dialog input fields for screen reader. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 71

(In reply to Jorg K (GMT+2) from comment #7)

Backport required here? This says "regression", but from bug 1569562 which
landed during the 71 cycle. So I assume this is working in TB 70 and TB 68
ESR, right?

Yes, it's for trunk only.

I confirm the bug is fixed completely. Many thanks

Best regards

Just a detail: is there a non-reg test for this?

Regards

I don't think so.

Should not we do one? To avoid future regression? I can run one with dogtail but I gues it would be beter to ship in Marionette?

Regards

You need to log in before you can comment on or make changes to this bug.