1581482 - Subject label has disappeared from screen reader (Daily 71)

Status: RESOLVED FIXED

(Thunderbird :: Disability Access, defect)

Description

[Jean-Philippe MENGUAL]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

In the latest nightly (regression introduced about 3 days ago):

1. ctrl-n
2. tab until the subject field

Actual results:

The screen reader does not say the field label

Expected results:

Should say "Subject", sent to at-spi. The label is no longer there

Comment 1

[Jorg K (CEST = GMT+2)]

I'm pretty sure this is from bug 1563121.

Comment 2

[Magnus Melin [:mkmelin]]

Maybe msgSubject needs a aria-labelledby="subjectLabel"
https://searchfox.org/comm-central/rev/45e763ae702e00168ffc2e8287315c2d1e5efffd/mail/components/compose/content/messengercompose.xul#2070

I suppose the xul controls= could have added that automatically earlier?

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1581482-subject-label.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a05365ba5266
Fix missing aria label on the Subject field of the compose dialog. r=mkmelin

Comment 6

[Jean-Philippe MENGUAL]

Hi,

I confirm the bug is fixed. Great

Thanks

Regards