1583017 - TEST-UNEXPECTED-FAIL | [snip]\mozmill\folder-widget\test-message-filters.js | test-message-filters.js::test_customize_toolbar_doesnt_double_get_mail_menu - Windows only

Status: NEW

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | Z:\task_1568977744\build\tests\mozmill\folder-widget\test-message-filters.js | test-message-filters.js::test_customize_toolbar_doesnt_double_get_mail_menu

This subtest doesn't run on Mac, seems to pass on Linux, fails on Windows.

This fails locally most times, not all the time, with:

SUMMARY-UNEXPECTED-FAIL | c:\mozilla-source\comm-central\comm\mail\test\mozmill\folder-widget\test-message-filters.js | test-message-filters.js::test_customize_toolbar_doesnt_double_get_mail_menu
  EXCEPTION: Timeout waiting for window to be focused.
    at: utils.jsm line 390
       TimeoutError utils.jsm:390 13
       waitFor utils.jsm:446 11
       wait_for_window_focused test-window-helpers.js:763 9
       check_getAllNewMsgMenu test-message-filters.js:99 28
       test_customize_toolbar_doesnt_double_get_mail_menu test-message-filters.js:116 3

If I take the call to wait_for_window_focused() out, it passes all the time.
https://searchfox.org/comm-central/rev/bc0151b8e00a5ac11a90ec58128ee1caceed33bb/mail/test/mozmill/folder-widget/test-message-filters.js#98

I don't know why this call is there in the first place. Previously a filter dialogue window was closed at line 84, so the main window should have focus again.

Now I can toss a coin whether to disable the test on Windows for now or just remove the call. I tried sleep() and focus() on the window, but that didn't help.

Range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c77eb3f5ee0513e76ff13f576de0c8003e&tochange=67ba5406ce3954311b41ea6bb5564118a5
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=1357e506bf3a&tochange=5156145ef2bc

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/902a5e76e4ef
temporarily disable test-message-filters.js::test_customize_toolbar_doesnt_double_get_mail_menu on Windows. rs=bustage-fix

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/01e2ce757bf7
Follow-up: linting fix. rs=white-space-only