1583019 - Crash in [@ PLDHashTable::Search | mozilla::dom::`anonymous namespace'::PrepareDatastoreOp::Cleanup]

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, defect, P1)

Description

[Jan Varga [:janv]]

This bug is for crash report bp-52e61a77-c98a-4afc-a57c-8a9030190913.

Top 10 frames of crashing thread:

0 xul.dll PLDHashTable::Search xpcom/ds/PLDHashTable.cpp:506
1 xul.dll void mozilla::dom::`anonymous namespace'::PrepareDatastoreOp::Cleanup dom/localstorage/ActorsParent.cpp:7732
2 xul.dll nsresult mozilla::dom::`anonymous namespace'::LSRequestBase::Run dom/localstorage/ActorsParent.cpp:6604
3 xul.dll void mozilla::dom::`anonymous namespace'::PrepareDatastoreOp::ActorDestroy dom/localstorage/ActorsParent.cpp:7844
4 xul.dll mozilla::ipc::IProtocol::DestroySubtree ipc/glue/ProtocolUtils.cpp:572
5 xul.dll mozilla::ipc::IProtocol::DestroySubtree ipc/glue/ProtocolUtils.cpp:560
6 xul.dll mozilla::ipc::PBackgroundParent::OnChannelError ipc/ipdl/PBackgroundParent.cpp:5984
7 xul.dll nsresult mozilla::detail::RunnableMethodImpl<mozilla::dom::Performance*, void  xpcom/threads/nsThreadUtils.h:1176
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
9 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1583019 - Cleanup PreparedDatastore only if it was added to gPreparedDatastores; r=asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3408771624ff
Cleanup PreparedDatastore only if it was added to gPreparedDatastores; r=asuth

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3408771624ff

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you're comfortable doing so.

Comment 5

[Jan Varga [:janv]]

Comment on attachment 9094458 [details]
Bug 1583019 - Cleanup PreparedDatastore only if it was added to gPreparedDatastores; r=asuth

Beta/Release Uplift Approval Request

• User impact if declined: Users may experience a rare crash.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's low volume crash, but it's also very simple patch.
• String changes made/needed: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094458 [details]
Bug 1583019 - Cleanup PreparedDatastore only if it was added to gPreparedDatastores; r=asuth

Crash fix, let's take this for beta 12.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/14706dc0f3aa