1583067 - Buttons in the Certificate Manager and Device Manager that open dialogs no longer work

Status: RESOLVED FIXED

(Core :: Security, defect, P1)

Description

[Jonathan Kamens]

In current Daily, you can't view or delete certificates:

1. Open Preferences
2. Select Privacy & Security
3. Click "Manage Certificates..." near the bottom
4. Select a certificate
5. Click "View..." and observe that nothing happens
6. Click "Delete..." and observe that nothing happens

Error console:

NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWindowWatcher.openWindow] pippki.js:39
viewCertHelper chrome://pippki/content/pippki.js:39
viewCerts chrome://pippki/content/certManager.js:492
oncommand chrome://pippki/content/certManager.xul:1
NS_ERROR_ILLEGAL_VALUE: certManager.js:463
deleteCerts chrome://pippki/content/certManager.js:463
oncommand chrome://pippki/content/certManager.xul:1

Regression:

7:00.96 INFO: Last good revision: a55d5e1c611a347d559d1853af54df68ebcc3d8d
7:00.96 INFO: First bad revision: 76caeacb09c7579451e2b2cf757bd5f5f518aae0
7:00.96 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a55d5e1c611a347d559d1853af54df68ebcc3d8d&tochange=76caeacb09c7579451e2b2cf757bd5f5f518aae0

Comment 1

[Jorg K (CEST = GMT+2)]

Looks like bug 1553804 forgot to add chrome=no onto the call here:
https://searchfox.org/mozilla-central/rev/e3fc8f8970491aef14d3212b2d052942f4d29818/security/manager/pki/resources/content/pippki.js#39

Firefox gives this when trying to delete a certificate:
NS_ERROR_ILLEGAL_VALUE: certManager.js:463
which is also a call to open a Window: window.openDialog("chrome://pippki/content/deletecert.xul",

Strange that only TB users seem to be handling certificates.

Comment 2

[Lars Viklund]

(In reply to Jorg K (GMT+2) from comment #1)

Strange that only TB users seem to be handling certificates.

One typically only deletes certificates when there's a need to, which is quite seldom given their typical lifetimes.
I am on Firefox and happened to have to do it today, incidentally, if you're looking for datapoints on who does what when :D

Comment 3

[Jorg K (CEST = GMT+2)]

Kris, you fixed viewing a certificate here:
https://hg.mozilla.org/mozilla-central/rev/b8dfe5ab5aba#l1.2

but deleting one still gives:
NS_ERROR_ILLEGAL_VALUE: certManager.js:463
deleteCerts chrome://pippki/content/certManager.js:463
oncommand chrome://pippki/content/certManager.xul:1

Comment 4

[Dana Keeler (she/her) [:keeler]]

chrome://pippki/content/device_manager.js:329 as well, and there may be others in that directory

Comment 7

[Pascal Chevrel:pascalc]

This is a tracked functional regression in 71 with duplicates filed. Wennie, could we get this assigned and prioritized please? Thanks.

Comment 8

[Johann Hofmann [:johannh]]

Attachment: Bug 1583067 - Use correct window opener for chrome windows in certManager.js. r=kmag

Comment 9

[Johann Hofmann [:johannh]]

Quite devastating that we don't seem to have a single test for any of this. Should probably file a follow-up.

Comment 10

[Francesco Lodolo [:flod]]

Looks like there's a lot more broken in the certificates manager (bug 1586414). Should that be duped against this one, and fix everything here?

Comment 11

[Jorg K (CEST = GMT+2)]

Should all be fixed here, I'd say. As far as I can tell, all those buttons launch windows which now don't work any more.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dfd2afee1bb
Use correct window opener for chrome windows in certManager.js. r=kmag

Comment 14

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9dfd2afee1bb

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Reproduced the issue with Firefox 71.0a1 (20190922213341) on Windows 10x64. "Delete or Distrust" button from "View Certificates" not working as well as "Load" and "Change Password" button from Device Manager.
The issue is verified fixed with Firefox 71.0b9 (20191111170815) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.

Comment 16

[Lars Viklund]

My experience is different.

The delete button does not work properly for me with Nightly on macOS. It appears to delete the certificate but it still exists and affects websites.

When I reopen the certificate manager or restart Firefox, the "deleted" certificate is back in the list.

Comment 17

[Gian-Carlo Pascutto [:gcp]]

Alexandru, can you check whether the certificate is actually gone and not just missing from the display temporarily? See the comment above.

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #17)

Alexandru, can you check whether the certificate is actually gone and not just missing from the display temporarily? See the comment above.

He is right. I didn't notice this, I was only checking for button functionality. The Certificate is deleted temporarily, after reopening the Certificate Manager the deleted certificate is back. Checked with Firefox 72.0a1 (20191114055112) and Firefox 71.0b9 (20191111170815) on Windows 10x64 and macOS 10.12.

Comment 19

[Francesco Lodolo [:flod]]

You should really open a different bug. This one was caused by bug 1553804, and as far as I can tell that was fixed (the button weren't doing anything before).

Comment 20

[Gian-Carlo Pascutto [:gcp]]

All the related bugs were duped to this one and Francesco Lodolo suggested earlier that they could all be fixed here (https://bugzilla.mozilla.org/show_bug.cgi?id=1583067#c10). Feel free to re-file if you disagree with him. I guess the problem is that the UI is now sending the correct stuff to the certificate manager, but the latter doesn't actually work? Hard to blame users for not understanding the internal distinctions here.

Comment 21

[Gian-Carlo Pascutto [:gcp]]

I filed the follow-up here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1596401

I'll re-close this and indicate it's only the UI that appears now (which really makes the bug worse, as now the feature appears to work when it doesn't!).