Closed Bug 1553804 Opened 5 years ago Closed 5 years ago

Shouldn't try to send Chrome BC to Content Process

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla71

Project Flags:

Fission Milestone

Tracking Flags:

Tracking

Status

firefox71

---

fixed

People

(Reporter: farre, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 1553804: Part 1 - Don't allow opening content windows with chrome openers. r=nika 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1553804: Part 2 - Assert opener BrowsingContext type always matches its own type. r=nika 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1553804: Part 3 - Assert we never create chrome BrowsingContexts in/send them to child processes. r=nika 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1553804: Part 4 - Make some evil tests less evil/failing. r=nika 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1553804: Part 5 - Fix callers which create chrome windows with content openers. r=nika 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review

Andreas Farre [:farre]

Reporter

Description

•

5 years ago

•

Edited

Figure out why https://searchfox.org/mozilla-central/source/docshell/base/BrowsingContext.cpp#808-810 is firing.

Andreas Farre [:farre]

Reporter

Updated

•

5 years ago

Assignee: nobody → afarre

Status: NEW → ASSIGNED

Fission Milestone: --- → ?

Andreas Farre [:farre]

Reporter

Updated

•

5 years ago

Summary: MOZ_ASSERT(!mozilla::Preferences::GetBool("fission.preserve_browsing_contexts", false) || IsContent()); → MOZ_ASSERT(!mozilla::Preferences::GetBool("fission.preserve_browsing_contexts", false) || IsContent()); in BrowsingContext::GetIPCInitializer

Neha Kochar [:neha]

Updated

•

5 years ago

Fission Milestone: ? → M3

Priority: -- → P2

Neha Kochar [:neha]

Updated

•

5 years ago

Fission Milestone: M3 → M4

Andreas Farre [:farre]

Reporter

Updated

•

5 years ago

Priority: P2 → P3

Nika Layzell [:nika] (ni? for response)

Comment 1

•

5 years ago

In bug 1555753, I'm removing this assertion because it's a bit of an odd assertion. We should still fix the underlying reason for the crash, namely that we're sending a non-content BrowsingContext to content.

Summary: MOZ_ASSERT(!mozilla::Preferences::GetBool("fission.preserve_browsing_contexts", false) || IsContent()); in BrowsingContext::GetIPCInitializer → Shouldn't try to send Chrome BC to Content Process

Neha Kochar [:neha]

Updated

•

5 years ago

Blocks: improve-bc

Kris Maglione [:kmag]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1553804: Part 1 - Don't allow opening content windows with chrome openers. r=nika — Details

Kris Maglione [:kmag]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1553804: Part 2 - Assert opener BrowsingContext type always matches its own type. r=nika — Details

Kris Maglione [:kmag]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1553804: Part 3 - Assert we never create chrome BrowsingContexts in/send them to child processes. r=nika — Details

Kris Maglione [:kmag]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1553804: Part 4 - Make some evil tests less evil/failing. r=nika — Details

Neha Kochar [:neha]

Updated

•

5 years ago

Assignee: afarre → kmaglione+bmo

Priority: P3 → P2

Kris Maglione [:kmag]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1553804: Part 5 - Fix callers which create chrome windows with content openers. r=nika — Details

Kris Maglione [:kmag]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika — Details

Andreas Farre [:farre]

Reporter

Updated

•

5 years ago

Blocks: 1575051

Pulsebot

Comment 8

•

5 years ago

Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1ed250faeb2e
Part 1 - Don't allow opening content windows with chrome openers. r=nika
https://hg.mozilla.org/integration/autoland/rev/3acf056e792e
Part 2 - Assert opener BrowsingContext type always matches its own type. r=nika
https://hg.mozilla.org/integration/autoland/rev/1574aecf3177
Part 3 - Assert we never create chrome BrowsingContexts in/send them to child processes. r=nika
https://hg.mozilla.org/integration/autoland/rev/acff4a663671
Part 4 - Make some evil tests less evil/failing. r=nika
https://hg.mozilla.org/integration/autoland/rev/301e0d883a5f
Part 5 - Fix callers which create chrome windows with content openers. r=nika
https://hg.mozilla.org/integration/autoland/rev/86b3d469b4ff
Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika

Daniel Varga [:dvarga]

Comment 9

•

5 years ago

Backed out 6 changesets (Bug 1553804) for browser-chrome failure at browser/base/content/test/general/browser_fullscreen-window-open.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx1014-64-shippable%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&revision=86b3d469b4ff9f22e5757f83450b956a4c769785

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267595056&repo=autoland&lineNumber=2071

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx1014-64-shippable%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&revision=af0fe61c3db069df2d363b611e6d466851c6a46f

[task 2019-09-20T06:35:04.183Z] 06:35:04     INFO - TEST-PASS | browser/base/content/test/general/browser_fullscreen-window-open.js | Opened Window is expected: test_open_with_pref_disabled_in_fullscreen - 
[task 2019-09-20T06:35:04.183Z] 06:35:04     INFO - Buffered messages logged at 06:35:01
[task 2019-09-20T06:35:04.183Z] 06:35:04     INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2019-09-20T06:35:04.183Z] 06:35:04     INFO - Version: 2.1 INTEL-12.9.22
[task 2019-09-20T06:35:04.183Z] 06:35:04     INFO - Vendor: Intel Inc.
[task 2019-09-20T06:35:04.183Z] 06:35:04     INFO - Renderer: Intel Iris OpenGL Engine
[task 2019-09-20T06:35:04.183Z] 06:35:04     INFO - FBO Texture Target: TEXTURE_2D
[task 2019-09-20T06:35:04.184Z] 06:35:04     INFO - Buffered messages logged at 06:35:04
[task 2019-09-20T06:35:04.184Z] 06:35:04     INFO - Finished: test_open_with_pref_disabled_in_fullscreen
[task 2019-09-20T06:35:04.184Z] 06:35:04     INFO - Console message: [JavaScript Error: "TypeError: this._inputFieldEvents is undefined" {file: "resource:///modules/UrlbarInput.jsm" line: 236}]
[task 2019-09-20T06:35:04.184Z] 06:35:04     INFO - Running test: test_open_from_chrome
[task 2019-09-20T06:35:04.184Z] 06:35:04     INFO - Buffered messages finished
[task 2019-09-20T06:35:04.184Z] 06:35:04     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_fullscreen-window-open.js | uncaught exception - NS_ERROR_ILLEGAL_VALUE:  at waitForWindowOpenFromChrome@chrome://mochitests/content/browser/browser/base/content/test/general/browser_fullscreen-window-open.js:319:10
[task 2019-09-20T06:35:04.184Z] 06:35:04     INFO - test_open_from_chrome@chrome://mochitests/content/browser/browser/base/content/test/general/browser_fullscreen-window-open.js:180:30
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - run@chrome://mochikit/content/browser-test.js:1647:9
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - 
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - Stack trace:
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1667
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - OnErrorEventHandlerNonNull*chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:1647
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - chrome://mochikit/content/browser-test.js:Tester:466
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - chrome://mochikit/content/browser-harness.xul:createTester/</<:255
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - GECKO(1722) | JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/general/browser_fullscreen-window-open.js, line 319: NS_ERROR_ILLEGAL_VALUE:
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: " {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_fullscreen-window-open.js" line: 319}]
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - waitForWindowOpenFromChrome@chrome://mochitests/content/browser/browser/base/content/test/general/browser_fullscreen-window-open.js:319:10
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - test_open_from_chrome@chrome://mochitests/content/browser/browser/base/content/test/general/browser_fullscreen-window-open.js:180:30
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - run@chrome://mochikit/content/browser-test.js:1647:9
[task 2019-09-20T06:35:04.185Z] 06:35:04     INFO - 
[task 2019-09-20T06:35:44.708Z] 06:35:44     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-09-20T06:35:44.708Z] 06:35:44     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_fullscreen-window-open.js | Test timed out - 
[task 2019-09-20T06:35:44.906Z] 06:35:44     INFO - GECKO(1722) | MEMORY STAT | vsize 8085MB | residentFast 641MB | heapAllocated 144MB
[task 2019-09-20T06:35:44.906Z] 06:35:44     INFO - TEST-OK | browser/base/content/test/general/browser_fullscreen-window-open.js | took 45253ms
[task 2019-09-20T06:35:44.911Z] 06:35:44     INFO - checking window state
[task 2019-09-20T06:35:44.911Z] 06:35:44     INFO - GECKO(1722) | must wait for focus

Flags: needinfo?(kmaglione+bmo)

Andreea Pavel [:apavel]

Comment 10

•

5 years ago

Kris, this generated mochitest chrome proc failures too
c3: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267595976&repo=autoland&lineNumber=3439

[task 2019-09-20T06:50:33.140Z] 06:50:33 INFO - TEST-START | layout/forms/test/test_bug665540.html
[task 2019-09-20T06:50:33.160Z] 06:50:33 INFO - GECKO(3248) | ++DOMWINDOW == 92 (0FD46C00) [pid = 3040] [serial = 92] [outer = 1D0F9940]
[task 2019-09-20T06:50:33.223Z] 06:50:33 INFO - GECKO(3248) | [3040, Main Thread] WARNING: Chrome windows may never have content windows as their openers.: file z:/build/build/src/toolkit/components/windowwatcher/nsWindowWatcher.cpp, line 744
[task 2019-09-20T06:50:33.223Z] 06:50:33 INFO - GECKO(3248) | [3040, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file z:/build/build/src/dom/base/nsGlobalWindowOuter.cpp, line 7300
[task 2019-09-20T06:50:33.230Z] 06:50:33 INFO - TEST-INFO | started process screenshot
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO - TEST-INFO | screenshot: exit 0
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO - TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug665540.html | uncaught exception - NS_ERROR_ILLEGAL_VALUE: at openFullscreenWindow@chrome://mochitests/content/chrome/layout/forms/test/test_bug665540.html:34:11
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO - onload@chrome://mochitests/content/chrome/layout/forms/test/test_bug665540.html:1:1
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO -
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO - simpletestOnerror@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1667:24
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO - OnErrorEventHandlerNonNull*@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1647:1
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO - GECKO(3248) | JavaScript error: chrome://mochitests/content/chrome/layout/forms/test/test_bug665540.html, line 34: NS_ERROR_ILLEGAL_VALUE:
[task 2019-09-20T06:50:33.305Z] 06:50:33 INFO - GECKO(3248) | MEMORY STAT | vsize 854MB | vsizeMaxContiguous 487MB | residentFast 324MB | heapAllocated 159MB
[task 2019-09-20T06:50:33.306Z] 06:50:33 INFO - TEST-OK | layout/forms/test/test_bug665540.html | took 110ms

c2: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267595965&repo=autoland&lineNumber=12024
INFO - TEST-START | dom/tests/mochitest/keyhandling/test_windowed.xul
INFO - GECKO(3952) | ++DOMWINDOW == 50 (1ED0D000) [pid = 2412] [serial = 50] [outer = 1CEF7A60]
INFO - GECKO(3952) | [2412, Main Thread] WARNING: Chrome windows may never have content windows as their openers.: file z:/build/build/src/toolkit/components/windowwatcher/nsWindowWatcher.cpp, line 744
INFO - GECKO(3952) | [2412, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file z:/build/build/src/dom/base/nsGlobalWindowOuter.cpp, line 7300
INFO - GECKO(3952) | [2412, Main Thread] WARNING: Failed to remove transaction listener from the editor: 'removedTransactionListener', file z:/build/build/src/editor/composer/nsEditingSession.cpp, line 464
INFO - GECKO(3952) | JavaScript error: chrome://mochitests/content/chrome/dom/tests/mochitest/keyhandling/test_windowed.xul, line 13: NS_ERROR_ILLEGAL_VALUE
INFO - GECKO(3952) | --DOCSHELL 10516C00 == 15 [pid = 2412] [id = {2db00abf-3159-4088-a84d-cdbdeeebe393}] [url = chrome://gfxsanity/content/sanityparent.html]
INFO - GECKO(3952) | --DOCSHELL 14908000 == 14 [pid = 2412] [id = {622526a9-9389-48c4-8886-1a724a1eadab}] [url = moz-extension://9f557d8b-a784-4ac1-b264-c9001b5af8f0/_generated_background_page.html]
INFO - GECKO(3952) | --DOCSHELL 0EBE5C00 == 13 [pid = 2412] [id = {139ffbd8-7b5b-4408-ae32-0a0a6e2173b6}] [url = chrome://gfxsanity/content/sanitytest.html]
INFO - GECKO(3952) | --DOCSHELL 1DF9A000 == 12 [pid = 2412] [id = {6df66dc6-c463-4f88-84d5-68dbf77a542c}] [url = chrome://mochitests/content/chrome/dom/tests/mochitest/keyhandling/browsertest.html]
INFO - GECKO(3952) | --DOCSHELL 1EDED400 == 11 [pid = 2412] [id = {6a1afe8b-6b16-46e7-82b1-008101dffd57}] [url = data:text/plain,Test text]
INFO - GECKO(3952) | --DOMWINDOW == 49 (16682800) [pid = 2412] [serial = 28] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 48 (14721C00) [pid = 2412] [serial = 8] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 47 (16CA3800) [pid = 2412] [serial = 30] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 46 (14724000) [pid = 2412] [serial = 10] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 45 (14909800) [pid = 2412] [serial = 16] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 44 (1490B400) [pid = 2412] [serial = 17] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 43 (1490CC00) [pid = 2412] [serial = 18] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 42 (1490E400) [pid = 2412] [serial = 19] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 41 (13628000) [pid = 2412] [serial = 34] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 40 (1CFADC00) [pid = 2412] [serial = 40] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 39 (1DC30800) [pid = 2412] [serial = 39] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 38 (0F57D5E0) [pid = 2412] [serial = 1] [outer = 00000000] [url = chrome://gfxsanity/content/sanityparent.html]
INFO - GECKO(3952) | --DOMWINDOW == 37 (1DCEF3A0) [pid = 2412] [serial = 42] [outer = 00000000] [url = chrome://mochitests/content/chrome/dom/tests/mochitest/keyhandling/browsertest.html]
INFO - GECKO(3952) | --DOMWINDOW == 36 (1DCEF4C0) [pid = 2412] [serial = 46] [outer = 00000000] [url = data:text/plain,Test text]
INFO - GECKO(3952) | --DOMWINDOW == 35 (0F57DCA0) [pid = 2412] [serial = 9] [outer = 00000000] [url = chrome://gfxsanity/content/sanitytest.html]
INFO - GECKO(3952) | --DOMWINDOW == 34 (149A03A0) [pid = 2412] [serial = 15] [outer = 00000000] [url = moz-extension://9f557d8b-a784-4ac1-b264-c9001b5af8f0/_generated_background_page.html]
INFO - GECKO(3952) | --DOMWINDOW == 33 (1C0BC000) [pid = 2412] [serial = 36] [outer = 00000000] [url = http://mochi.test:8888/redirect.html]
INFO - GECKO(3952) | --DOMWINDOW == 32 (1DF98C00) [pid = 2412] [serial = 41] [outer = 00000000] [url = chrome://mochitests/content/chrome/dom/tests/mochitest/keyhandling/test_browser.xul]
INFO - GECKO(3952) | --DOMWINDOW == 31 (14910C00) [pid = 2412] [serial = 20] [outer = 00000000] [url = chrome://gfxsanity/content/sanitytest.html]
INFO - GECKO(3952) | --DOMWINDOW == 30 (1DF9B000) [pid = 2412] [serial = 43] [outer = 00000000] [url = chrome://mochitests/content/chrome/dom/tests/mochitest/keyhandling/browsertest.html]
INFO - GECKO(3952) | --DOMWINDOW == 29 (1EDEE000) [pid = 2412] [serial = 47] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 28 (10518800) [pid = 2412] [serial = 2] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | --DOMWINDOW == 27 (1EDEF400) [pid = 2412] [serial = 48] [outer = 00000000] [url = data:text/plain,Test text]
INFO - GECKO(3952) | --DOMWINDOW == 26 (1ED0B400) [pid = 2412] [serial = 49] [outer = 00000000] [url = chrome://mochikit/content/tests/SimpleTest/iframe-between-tests.html]
INFO - GECKO(3952) | --DOMWINDOW == 25 (1EDEBC00) [pid = 2412] [serial = 45] [outer = 00000000] [url = chrome://mochitests/content/chrome/dom/tests/mochitest/keyhandling/test_editor.xul]
INFO - GECKO(3952) | --DOMWINDOW == 24 (1EDEA800) [pid = 2412] [serial = 44] [outer = 00000000] [url = chrome://mochikit/content/tests/SimpleTest/iframe-between-tests.html]
INFO - GECKO(3952) | --DOMWINDOW == 23 (14DF9C00) [pid = 2412] [serial = 25] [outer = 00000000] [url = moz-extension://9f557d8b-a784-4ac1-b264-c9001b5af8f0/_generated_background_page.html]
INFO - GECKO(3952) | --DOMWINDOW == 22 (16CA8000) [pid = 2412] [serial = 31] [outer = 00000000] [url = about:blank]
INFO - GECKO(3952) | [2412, Jump List] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file z:/build/build/src/widget/windows/WinUtils.cpp, line 1346
INFO - GECKO(3952) | [2412, Jump List] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file z:/build/build/src/widget/windows/WinUtils.cpp, line 1346
INFO - TEST-INFO | started process screenshot
INFO - TEST-INFO | screenshot: exit 0
INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/keyhandling/test_windowed.xul | Test timed out.
INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:22
INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:18
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:170:15
INFO - TestRunner.runTests/<@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:388:20
INFO - promise callbackTestRunner.runTests@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:375:50
INFO - RunSet.runtests@chrome://mochikit/content/tests/SimpleTest/setup.js:201:14
INFO - RunSet.runall@chrome://mochikit/content/tests/SimpleTest/setup.js:180:12
INFO - hookupTests@chrome://mochikit/content/tests/SimpleTest/setup.js:273:12
INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:50:13
INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:61:28
INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:57:3
INFO - hookup@chrome://mochikit/content/tests/SimpleTest/setup.js:253:20
INFO - linkAndHookup@chrome://mochikit/content/harness.xul:45:3
INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:50:13
INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:61:28
INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:57:3
INFO - getTestList@chrome://mochikit/content/chrome-harness.js:258:18
INFO - loadTests@chrome://mochikit/content/harness.xul:24:14
INFO - EventListener.handleEvent*@chrome://mochikit/content/harness.xul:48:12
INFO - GECKO(3952) | MEMORY STAT | vsize 837MB | vsizeMaxContiguous 507MB | residentFast 264MB | heapAllocated 79MB
INFO - TEST-OK | dom/tests/mochitest/keyhandling/test_windowed.xul | took 328779ms

Kris Maglione [:kmag]

Assignee

Comment 11

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a4107e9e2af35b7db7cee4d180d6af3b3515af4
Bug 1553804: Part 1 - Don't allow opening content windows with chrome openers. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/f49f7a96f2246172ea75c3791d97c0011094e4b7
Bug 1553804: Part 2 - Assert opener BrowsingContext type always matches its own type. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe63cdb9480a1363bde86c282ef69edaeb302638
Bug 1553804: Part 3 - Assert we never create chrome BrowsingContexts in/send them to child processes. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b896aec5ba12acc4bb755a595b0b52547d07678
Bug 1553804: Part 4 - Make some evil tests less evil/failing. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/56c14ca1d9e89633d4e635d77fdf44e1cc6d75dc
Bug 1553804: Part 5 - Fix callers which create chrome windows with content openers. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/19c33f741d779768f53eed13e5c0f45e0363f537
Bug 1553804: Part 6 - Fix chrome mochitests which open chrome windows with content openers. r=nika

Kris Maglione [:kmag]

Assignee

Comment 12

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/56b4b4b865004746832f6d9b578178b5a17b1d44
Bug 1553804: Follow-up: Fix another straggling chrome mochitest failure. r=bustage

Kris Maglione [:kmag]

Assignee

Comment 13

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/461a6e9e829bcbb4ef83cc660f0fdfa98e7c6a75
Bug 1553804: Follow-up: Fix another intermittent browser chrome failure. r=bustage

Arthur Iakab [arthur_iakab]

Comment 14

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0a4107e9e2af
https://hg.mozilla.org/mozilla-central/rev/f49f7a96f224
https://hg.mozilla.org/mozilla-central/rev/fe63cdb9480a
https://hg.mozilla.org/mozilla-central/rev/2b896aec5ba1
https://hg.mozilla.org/mozilla-central/rev/56c14ca1d9e8
https://hg.mozilla.org/mozilla-central/rev/19c33f741d77
https://hg.mozilla.org/mozilla-central/rev/56b4b4b86500
https://hg.mozilla.org/mozilla-central/rev/461a6e9e829b

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox71: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla71

Noemi Erli[:noemi_erli]

Updated

•

5 years ago

Regressions: 1582950

Francesco Lodolo [:flod]

Updated

•

5 years ago

Regressions: 1583114

Jorg K (CEST = GMT+2)

Updated

•

5 years ago

Regressions: 1583067

Kestrel

Updated

•

5 years ago

Regressions: 1583886

Nicolas Chevobbe [:nchevobbe]

Updated

•

5 years ago

Regressions: 1583972

Kestrel

Updated

•

5 years ago

Regressions: 1585710

Francesco Lodolo [:flod]

Updated

•

5 years ago

Regressions: 1586414

Kris Maglione [:kmag]

Assignee

Updated

•

5 years ago

Flags: needinfo?(kmaglione+bmo)

Gian-Carlo Pascutto [:gcp]

Updated

•

5 years ago

Regressions: 1596401

:Gijs (he/him)

Updated

•

4 years ago

Regressions: 1603485

Kestrel

Updated

•

4 years ago

Regressions: 1607201

Johann Hofmann [:johannh]

Updated

•

4 years ago

No longer regressions: 1596401

You need to log in before you can comment on or make changes to this bug.