Closed Bug 1583161 Opened 5 years ago Closed 5 years ago

The FxA avatar's hover effect is hardly visible on dark mode

Categories

(Firefox :: about:logins, defect, P3)

Product:
Firefox
Component:
about:logins
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- wontfix
firefox71 --- verified

People

(Reporter: cmuntean, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(2 files)

hover in dark mode.mov
312.62 KB, video/quicktime
Details
Bug 1583161 - Remove the border from the FxA avatar in about:logins since it was cropping the avatar and looked odd in Dark mode. r?MattN
47 bytes, text/x-phabricator-request
Details | Review
Attached video hover in dark mode.mov —

[Affected Versions]:

  • Nightly 71.0a1
  • Beta 70.0b8

[Affected Platforms]

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]

  • You are signed with a valid FxA that has a custom avatar set.
  • Heave the Dark Theme set.

[Steps to reproduce]:

  1. Open the latest Nightly browser with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Hover the FxA avatar.
  4. Observe the hover effect.

[Expected results]:

  • The hover effect is visible.

[Actual results]:

  • The hover effect is hardly visible

[Notes]:

  • The issue is not visible on white theme.
  • Attached a screen recording with the issue.

For this and bug 1583160, I think we'll just want to remove the border on the avatar.

Priority: -- → P3
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Version: 71 Branch → unspecified
Assignee: nobody → jaws
Status: NEW → ASSIGNED
See Also: → 1583160
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f0ab2cdb240
Remove the border from the FxA avatar in about:logins since it was cropping the avatar and looked odd in Dark mode. r=MattN

https://hg.mozilla.org/mozilla-central/rev/2f0ab2cdb240

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191010214019) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

  • The border from the FxA avatar is removed.
  • The FxA avatar doesn't have anymore hover effect.
Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: