1583203 - Annotate nsINode::OwnerDoc as returning non-null.

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1583203 - Annotate nsINode::OwnerDoc() as MOZ_NONNULL_RETURN.

People keep adding useless null-checks and it was not clear what the consensus
was from bug 1441165, but this should be unobjectionable I guess.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e3eebe862e5
Annotate nsINode::OwnerDoc() as MOZ_NONNULL_RETURN. r=smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bc17415ff25
followup: Remove some silly null-checks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca89485fedf8
followup: Remove another silly null-check.

Comment 5

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=3e3eebe862e515d9c3206a7dc15fbeeedcbe1fee&tochange=e3c0a8d81a1470943594ff08dc1e3155da02de45

Failure log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=267976604&repo=autoland&lineNumber=33425

Backout: https://hg.mozilla.org/integration/autoland/rev/e3c0a8d81a1470943594ff08dc1e3155da02de45

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46de0744bc95
Annotate nsINode::OwnerDoc() as MOZ_NONNULL_RETURN. r=smaug

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/46de0744bc95