Closed Bug 1583237 Opened 2 months ago Closed 2 months ago

Wrap the dark mode CSS from 035571ecb663 with a @supports -moz-bool-pref conditional

Categories

(Toolkit :: Password Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox69 --- unaffected
firefox70 + fixed
firefox71 + fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management])

Attachments

(1 file)

In the event that we disable "browser.in-content.dark-mode", we'll want this CSS to no longer apply.

We should be able to do this with:
@supports not (-moz-bool-pref("browser.in-content.dark-mode")) { ... }

[Tracking Requested - why for this release]: breaks the browser.in-content.dark-mode pref on about:logins, which means we can't easily pref-off the dark mode feature (unlikely at this point, but who knows).

Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c79a2264e1e5
Add fallback to set the in-content-deemphasized-text color in case the user has prefers-color-scheme set to dark but the in-content dark-mode pref is disabled. r=ntim
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Is this something that you think would be good for beta uplift?

Flags: needinfo?(jaws)

Yeah, we should uplift this just in case we want to disable the in-content dark-mode pref post 70 release.

Flags: needinfo?(jaws)

Comment on attachment 9094740 [details]
Bug 1583237 - Add fallback to set the in-content-deemphasized-text color in case the user has prefers-color-scheme set to dark but the in-content dark-mode pref is disabled. r?ntim

Beta/Release Uplift Approval Request

  • User impact if declined: In the event that we want to disable in-content dark-mode, the color of this text will be incorrect for users who have dark mode enabled.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): simple revert of CSS if the preference is disabled.
  • String changes made/needed: none
Attachment #9094740 - Flags: approval-mozilla-beta?

Comment on attachment 9094740 [details]
Bug 1583237 - Add fallback to set the in-content-deemphasized-text color in case the user has prefers-color-scheme set to dark but the in-content dark-mode pref is disabled. r?ntim

Allows tweaking of dark mode, OK for uplift for beta 13.

Attachment #9094740 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.