1583400 - HasActiveDocument() needs updating to work with Fission

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Paul Bone [:pbone]]

HasActiveDocument() needs updating to work with Fission.

https://searchfox.org/mozilla-central/source/dom/base/nsPIDOMWindowInlines.h#55

Kmag says that HasActiveWindow should check if the browsing context has the correct inner window.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1583400 - Fix HasActiveDocument for fission r=kmag

This change also uninlines this method so that it can access the
BrowsingContext object without re-ordering C++ headers.

Comment 2

[Paul Bone [:pbone]]

I've been trying to figure out why my patches don't work. I'm not getting very far and will have to give up and move on to something else.

But here's my notes regarding the attached patch.

There are some cases with this patch that fail in non-fision mode because the browsing context as a null mDocShell. While without the patch the inner window can find the outer window without going via the BrowsingContext. This is in the dom/ipc/tests/test_window_open_discarded_bc.html test.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1583400: Make IsCurrentInnerWindow Fission-compatible. r=bzbarsky

In the cases where we call IsCurrentInnerWindow(), we care whether the inner
window is the current one for a BrowsingContext, rather than for a
GlobalWindowOuter, which is not always the same thing after a cross-process
navigation.

This patch fixes the logic to compare against the current window for the
BrowsingContext, and also updates HasActiveDocument() to simply check
IsCurrentInnerWindow(), which should be all that's necessary now that
document.open() no longer creates new inner windows.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/686a306609ad
Make IsCurrentInnerWindow Fission-compatible. r=bzbarsky

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1583400: Follow-up: Fix cycle collector assertion.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/686a306609ad
https://hg.mozilla.org/mozilla-central/rev/6f876f24a948