1588220 - Only last active inner window should be reported as current after a BrowsingContext is discarded

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Kris Maglione [:kmag]]

After a BrowsingContext is discarded, it drops its reference to its DocShell, and loses track of what its last active inner window was. Since inner windows still sometimes need to behave slightly differently when their BC was discarded while they were still the active inner window vs. when they were not, bug 1583400 works around this by simply checking if an inner window is current relative to its BrowsingContext if its BC has not been discarded, and whether it is current relative to its outer if it has not. This is more correct than always checking relative to its outer, but still incorrect when the outer window was not the active window for the BrowsingContext when it was discarded.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1588220: Keep track of last active inner window when BrowsingContext is discarded. r=bzbarsky

Any number of outer windows may be attached to a BrowsingContext over its
lifetime. While the BrowsingContext is alive, it's easy to keep track of which
of these is active, and therefore which of its inner windows is active. After
it has been discarded, though, it discards its docShell reference, so all we
can tell about an inner window is whether it is active for its own outer
window, but not whether it should be considered active for its
BrowsingContext.

This patch updates the BrowsingContext detach logic to store a flag on the
current inner window recording that it was active when its BrowsingContext was
detached, and then later checks that flag to determine if it is the current
window for a detached BrowsingContext.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36a8c8887629
Keep track of last active inner window when BrowsingContext is discarded. r=bzbarsky

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/36a8c8887629

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out changeset 36a8c8887629 (bug 1588220) for causing a spike in browser chrome failures (eg: Bug 1592741)

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=cf03264ec46e2ba479d759efba640b0cf9c44a70&searchStr=browser%2Cchrome&fromchange=6c15753220e01a46d57a5b8694ef1c51dcbd2262&selectedJob=273802821

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=273802821&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=273735790&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/0484fd2a471df0bc9711f888081b2b6daaee0301

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged on 2019-10.-31:
https://hg.mozilla.org/mozilla-central/rev/0484fd2a471d

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36a8c8887629

Comment 7

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98af9fbfc0ec
Keep track of last active inner window when BrowsingContext is discarded. r=bzbarsky

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/98af9fbfc0ec

Comment 11

[Andrew McCreight [:mccr8]]

Kris landed the patch.