1583446 - Enabling Search in all channels

Status: VERIFIED FIXED

(DevTools :: Netmonitor, task, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

We've enabled the Search feature in Nightly and DevEdition in bug 1581088

This report is about enabling it in all channels (Beta and Release)

Honza

Comment 1

[:Harald Kirschner :digitarald]

We should uplift this to 71 to let Search ride to release.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1583446 - Enabling Search in all channels

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

QA Manual Testing Summary green:
https://testrail.stage.mozaws.net/index.php?/reports/view/2086

QA meta bug 1584547

• blockers fixed

Plan: Land in 72 and uplift to 71

Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ad1ce4c84fa
Enabling Search in all channels r=Harald

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8ad1ce4c84fa

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9107463 [details]
Bug 1583446 - Enabling Search in all channels

Beta/Release Uplift Approval Request

• User impact if declined: Developers not having Search across all HTTP requests (in the Network panel) available by default.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature was available in Nightly for testing, it's bee also available in DevEdition and it went through QA testing.
• String changes made/needed:

Comment 8

[Pascal Chevrel:pascalc]

Same as bug 1573805, I am not seeing any card about enabling this feature in 71 in our Firefox Trello and we are nearing the end of the beta cycle, I would like Tania to shime in for QA before taking an uplift to beta.

Comment 9

[Brindusa Tot, Desktop QA]

Hi Pascal,
I suppose that the trello card for this is https://trello.com/c/J96b3DcJ/794-network-full-text-search

Also, there is this PI: https://jira.mozilla.com/browse/PI-268 for the Fx71 train and we are working on this. Testing for Preliminary Pre-Release for Fx 71 is in progress for this feature (DevTools: Network Panel Search)

Jan, can you take a look at the mention trello card and see if it is the one corresponding for the PI-268?

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Brindusa Tot[:brindusat] from comment #9)

Jan, can you take a look at the mention trello card and see if it is the one corresponding for the PI-268?

Correct this is the one related to this bug.

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9107463 [details]
Bug 1583446 - Enabling Search in all channels

QA gave the green light last Friday, uplift approved for 71 beta 11, thanks.

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c91f90179bb4

Comment 13

[Marcela (Please NI request to Brindusa Tot)]

I verified this issue on Windows 10, Ubuntu 18.04, macOS 10.14 with FF 71.0b11 and I can confirm the fix.

Comment 14

[Julien Cristau [:jcristau]]

Please don't clear tracking flags.

Comment 15

[Marcela (Please NI request to Brindusa Tot)]

I Verified on Windows 10, macOS 10.14, Ubuntu 18.04 with latest Nightly version 72.0a1 and I can confirm the fix.