1583550 - Support additional targets in the OBT when we highlight the dock icon in case of breakpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

This particular code:
https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox-process-window.js#259-265
doesn't work with the changes landed in bug 1578408.
We must ensure that we do listen for paused event on all targets, not only the top level one.
To do that, we may use the upcoming Resource API which is still in process of being written, or emit an event from the toolbox, each time we receive a paused event.

Comment 1

[Alexandre Poirot [:ochameau]]

I should have provided a fixed revision searchfox link, here is one:
https://searchfox.org/mozilla-central/rev/3300072e993ae05d50d5c63d815260367eaf9179/devtools/client/framework/toolbox-process-window.js#289-291

This bug should be actionable as bug 1471754 landed.
The goal would be to use Toolbox's targetList in order to watch for all targets and listen to all target's thread fronts.
So that we update the dock icon if any thread pauses, instead of updating it only for the top level parent process target.
The target list API to use would be the following:
toolbox.targetList.watchTargets(toolbox.targetList.ALL_TYPES, onTargetAvailable, onTargetDestroyed)

Comment 2

[Jason Laster [:jlast]]

Attachment: Bug 1583550 - Support additional targets in the OBT when we highlight the dock icon in case of breakpoints. r=jdescottes

Comment 3

[Jason Laster [:jlast]]

Attachment: Bug 1583550 - Highlight toolbox paused state. r=jdescottes

Comment 4

[Jason Laster [:jlast]]

Attachment: Bug 1583550 - Highlight toolbox paused state. r=jdescottes

Comment 5

[Jason Laster [:jlast]]

Attachment: Bug 1583550 - Highlight toolbox paused state. r=jdescottes

Comment 6

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6fdd3c5b7dd
Highlight toolbox paused state. r=jdescottes

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d6fdd3c5b7dd