1583616 - Suggestion for https://www.1001tracklists.com incorrectly prompts to search instead of visit

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Asif Youssuff]

STR:

1. Navigate to https://www.1001tracklists.com once, to establish autocomplete
2. Type "1001" into the bar.

What happens:

Firefox autocompletes my entry to 1001tracklists.com/ but shows that it will search with my search engine for "1001" if I press enter.

Expected result:

Firefox will "visit" 1001tracklists.com/ instead of searching.

Reported on reddit:

https://www.reddit.com/r/firefox/comments/d8qp0q/why_is_autocomplete_behaving_unreliably_here/

9:23.63 INFO: No more inbound revisions, bisection finished.
9:23.63 INFO: Last good revision: 99a6defccec0caa61a65fddb3b9ea4b416133662
9:23.63 INFO: First bad revision: 3779a2682cc744ca22372a94ea3befe0fccf7029
9:23.63 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=99a6defccec0caa61a65fddb3b9ea4b416133662&tochange=3779a2682cc744ca22372a94ea3befe0fccf7029

Comment 1

[Asif Youssuff]

Marco, can you look into this regression caused by your patch in bug 1537640? Thanks!

Comment 2

[Asif Youssuff]

Attachment: c0WJJuI.png

Comment 3

[Marco Bonardo [:mak]]

Yes, I'll have a look at this.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1583616 - Some numbers are searched and not autofilled. r=Standard8

The tokenizer currently thinks large numbers are "broken" IPs, thus it says they
can't be an origin. Unfortunately we use that same code path to identify possible
origin prefixes, and origins can start with a number. Thus we end up searching
rather than autofilling the origin.

For now fix the heuristic for IPs, in the future we may evaluate splitting these
code paths.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e7ce1c4f3f0
Some numbers are searched and not autofilled. r=Standard8

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2e7ce1c4f3f0

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Unless you feel strongly about getting this into 70 release, I'd like to let this ride the trains with 71.