1583816 - Store associated JSFunction directly in JSScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

With Bug 1568245 landed, we can now move the functionNonDelazifying behaviour to BaseScript. We also set the BaseScript::functionOrGlobal field to the canonical function for JSScript to be consistent with LazyScript.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1583816 - Store associated JSFunction directly in JSScript

For function JSScripts, store the JSFunction in the BaseScript
functionOrGlobal field. This makes JSScript more consistent with the
LazyScript behaviour.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1583816 - Add BaseScript::functionNonDelazifying() and simplify code

Instead of checking for canonical function using scope chain, we can
directly use the functionOrGlobal field. By moving this to the
BaseScript class we can also simplify the debugger acccess.

Depends on D47070

Comment 3

[Ted Campbell [:tcampbell]]

Needs Bug 1583860 fixed to avoid intermittent tsan failures.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2736f38dd2ce
Store associated JSFunction directly in JSScript r=jandem
https://hg.mozilla.org/integration/autoland/rev/73734a2e8547
Add BaseScript::functionNonDelazifying() and simplify code r=jandem

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2736f38dd2ce
https://hg.mozilla.org/mozilla-central/rev/73734a2e8547

Comment 6

[Ted Campbell [:tcampbell]]

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1585101#c2

Coverage relies on being able to access canonical function during finalization. This previously worked by finding it via the js::Scope. With these patches, the functionOrGlobal_ field is cleared out and we cannot find the canonical function. I'm not sure what the best work around is.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb56e5bd2203
Backed out 2 changesets for causing ccov crashes CLOSED TREE

Comment 8

[Ted Campbell [:tcampbell]]

This is unfortunately coupled to Bug 1585372. I'll part 1 one of this bug first to make the JSFunction available to coverage::InitScriptCoverage. Then I can land Bug 1585372, and finally part 2 of this bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46c2aeec2408
Store associated JSFunction directly in JSScript r=jandem

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/46c2aeec2408

Comment 11

[Ted Campbell [:tcampbell]]

Breaking part 2 into a separate bug since part 1 was useful on own and landed in previous cycle.

Comment 12

[Phabricator Automation]

Comment on attachment 9095157 [details]
Bug 1583816 - Add BaseScript::functionNonDelazifying() and simplify code

Revision D47071 was moved to bug 1591405. Setting attachment 9095157 [details] to obsolete.