1583860 - Intermittent js/src/jit-test/tests/bug1375074.js | ================== (code 66, args "--ion-eager --ion-check-range-analysis --ion-extra-checks --no-sse3") [1.2 s]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: tcampbell [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=268363232&repo=try
Full log: https://queue.taskcluster.net/v1/task/Yf5_NmfLRV6111R2KzXssw/runs/0/artifacts/public/logs/live_backing.log

---

This is a tsan failure on try, but I believe the issue is related to Bug 1568245.

Comment 1

[Ted Campbell [:tcampbell]]

https://searchfox.org/mozilla-central/rev/45f30e1d19bde27bf07e47a0a5dd0962dd27ba18/js/src/jit/IonBuilder.cpp#1154

We should not be accessing JSScript::realm() directly from off-thread anymore. Can probably store the realm in the IonBuilder.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1583860 - Don't access JSScript::realm() off-thread. r?jandem

It is no longer safe to access JSScript::realm() off-thread. That is
okay because IonBuilder already has a CompileRealm for us to use.

Comment 3

[Intermittent Failures Robot]

1 failures in 4530 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1583860&startday=2019-09-23&endday=2019-09-29&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c520d4083fa2
Don't access JSScript::realm() off-thread. r=jandem

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c520d4083fa2