1583831 - Missing string in nsserrors.ftl for PR_END_OF_FILE_ERROR

Status: RESOLVED DUPLICATE of bug 1584585

(Firefox :: Security, defect)

Description

[Guinness]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Tried to access this URL : https://freelibrary.host/?hash=QNxUWN5EGO3kzM1IDNiBTNkRTOmNjNjVDdz9GauknchJnYpxWZlJnZ

Actual results:

A template variable appears instead of being replaced by its value.

Expected results:

The variable of the template shouldn't appear.
It seems that the .ftl file for nss errors does not includes an entry for the PR_END_OF_FILE_ERROR.
Something like

pr-end-of-file = The peer closed unexpectedly the connection.

should be sufficient.
I'm not sure of the formulation though.
I can submit a patch when we agree on a formulation?

Comment 1

[Clément Lefèvre]

(Confirming the bug on nightly; stable is unaffected)

Comment 2

[Liviu Seplecan]

Same in my end in Ubuntu 18.04 - nighlty 71.0a1, beta 70.0b10, release 69.0.1. Further I will set a component for the issue, if isn't the right one please fell free to change it.
Regards,
Liviu

Comment 3

[Marcus Burghardt]

In NSPR, the value of this variable is "Encountered end of file".
https://searchfox.org/mozilla-central/source/nsprpub/pr/src/misc/prerr.c#75

In NSS, this error is reached during the handshake in two places:
https://searchfox.org/mozilla-central/source/security/nss/lib/ssl/sslcon.c#83
https://searchfox.org/mozilla-central/source/security/nss/lib/ssl/sslsecur.c#376

So, I suggested to follow the same standard message for this VARIABLE.
Guinness, this patch looks to be outside the NSS scope and I will confirm that, but you can go ahead and push a patch for review. : )

Thanks,

Comment 4

[J.C. Jones [:jcj] (he/they)]

Johann, can you help me find the right triage for this one? Thanks!

Comment 5

[Johann Hofmann [:johannh]]

Technically this is a dupe of bug 1584585 (it should just stay blank if there's no translation) but feel free to re-open this if you want to add a new string anyway.