1584585 - Add more error messages to fluent files for about:neterror

Status: NEW

(Core :: Networking, defect, P3)

Description

[Ed Lee :Mardak]

Attachment: screenshot of PR_CONNECT_RESET_ERROR

Guessing this is from bug 1561443 as it added this code:

https://searchfox.org/mozilla-central/rev/23f836a71cfe961373c8bd0d0219ec60a64b3c8f/browser/base/content/aboutNetError.js#355-366

errorCodeStr should be PR_CONNECT_RESET_ERROR as it's shown as-is slightly below {$errorMessage}

So errorCodeMsg seems like it's trying to get localized pr-connect-reset-error, which does not exist.

"ssl-connection-error" does get hostname just not errorMessage as shown attached.

Comment 1

[Johann Hofmann [:johannh]]

Prathiksha, do you have time to take a look at this?

Comment 4

[Johann Hofmann [:johannh]]

[Tracking Requested - why for this release]:
Visual regression in error pages that makes us look bad

Comment 6

[Johann Hofmann [:johannh]]

Bug 1583831 gave us an easy way to reproduce this: https://freelibrary.host/?hash=QNxUWN5EGO3kzM1IDNiBTNkRTOmNjNjVDdz9GauknchJnYpxWZlJnZ

Comment 7

[Guinness]

Attachment: Bug 1584585 - Add a message for the PR_END_OF_FILE_ERROR

Comment 8

[Guinness]

Can this bug be assigned to me so I can work on it properly?
I added a patch before it was attached (a lack of knowledge on my side).
I'd like to track all messages that are missing and add everything if possible.

Comment 9

[Guinness]

Moreover, I can patch the Js code in order to have an empty field for errorMessage if necessary.

Comment 10

[Johann Hofmann [:johannh]]

To be clear, the correct fix for this is in this patch: https://phabricator.services.mozilla.com/D47524

Adding new error messages is fine, but we should definitely fix the variable name.

Thanks!

Comment 11

[Guinness]

Oh indeed, I didn't remember but I made myself the same remark a few days ago when working on Bug 1583831.
I will have a look at https://searchfox.org/mozilla-central/source/nsprpub/pr/src/misc/prerr.c#75 to see which messages should be added to nsserrors.ftl

Comment 12

[Johann Hofmann [:johannh]]

Hi, are you still working on this? We would like to land https://phabricator.services.mozilla.com/D47524 and there's not really a need to add new messages at this point if it means delaying the fix (which it probably would, due to copy nit-picking).

Do you want me to re-open the other bug and land the variable name fix so that you can work on the updated strings here?

Comment 13

[Guinness]

Maybe it will be easier to open another bug for the strings, not to delay the variable name fix.
Sorry for disappearing for two days, I have some serious IPL issues to deal with.

Comment 14

[Johann Hofmann [:johannh]]

Ok, no worries, thank you for your help, let me re-open the other bug and land the fix then :)

Comment 15

[Julien Cristau [:jcristau] (back August 5)]

Dropping the status flags since the immediate issue was fixed in bug 1584685.

Comment 16

[Mathew Hodson]

You need to remove the regressed by bug 1561443 if you want to remove the regression tag. Otherwise, the bot will add the tag back.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:sgalich, could you have a look please?
For more information, please visit auto_nag documentation.