1583972 - Deprecation warning in scratchpad does not work as a link to more information

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Today's (Sept 25) Mac nightly

STEPS TO REPRODUCE:

1. Start browser.
2. Go to Tools > Web Developer > Scratchpad in the main menu
3. In the window that pops up, click the "Learn more...." text in the yellow deprecation infobar.

EXPECTED RESULTS: I learn more.

ACTUAL RESULTS: Nothing happens, and I remain ignorant.

Comment 1

[Boris Zbarsky [:bzbarsky]]

These steps also show the problem:

1. Start browser.
2. Go to Tools > Web Developer > Browser Toolbox in the main menu
3. Select "Scratchpad" tab.
4. Click the "Learn more...." text in the yellow deprecation infobar.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I can reproduce. using mozregression I was able to narrow it down to this pushlog https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=de5a09d263ff557012c5872a9edfb276ca1e353f&tochange=5ac55079c87e4cd25eafafa8662594b4a2917dcc

Bug 1553804 looks like a solid candidate for this regression

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1583972 - Fix deprecation link opening in Scratchpad window. r=jdescottes.

Bug 1553804 made opening a content page from a Chrome
document a no-op, which broke the deprecation warning
in the Scratchpad window.
We switch to a JS solution using openDocLink on link
click.
I tried playing with rel=noopener, but the opened link
was about:blank for some reason I can't explain.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d815ac4c9b96
Fix deprecation link opening in Scratchpad window. r=jdescottes.

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d815ac4c9b96