1584032 - Ignore about:blank for some events in actor registration

Status: RESOLVED WONTFIX

(Core :: DOM: Content Processes, defect)

Description

[Neil Deakin]

The work-in-progress password manager and autocomplete listen for pageshow/load events and are declared as such in their actor registration.

However, this causes pageshow firing on about:blank to load the actor's module during startup causing the browser_startup_content.js to fail.

If I manually change JSWindowActorService to just ignore events for about:blank this causes the test to pass and the module to be loaded later.

It would be ideal if a better check could be incorporated that would handle this.

What would be the best way to do this in a configurable way? An event flag? A general flag that just manually handle specific events?

Comment 1

[Neil Deakin]

Another option is to add a 'not' option to the matches syntax.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey jdai, do you have any thoughts on this?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

:kmag and I have discussed this a bit. It's not a good option here to filter based on the URI being loaded, as a document which has about:blank loaded in it can often have real data loaded in it as well. In general we don't want to encourage doing filtering based on URI like that, as it's often the wrong thing to do given the existence of non-initial about:blank documents, and initial about:blank documents with web content.

The problem appears to be that this module is loading "early" during the startup of a content process, however I'm not sure if that is a serious issue, given that the module will be immediately loaded anyway for the first document rendered in the process. As we're not going to be avoiding loading this module during start-up, no matter what, it's probably OK that we're loading it for this particular initial about:blank document.

Neil, am I interpreting what the issue is correctly?

Comment 4

[Neil Deakin]

Yes, I can just add the various scripts to the startup script test.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Neil Deakin]

Don't need this anymore at least for the password manager.