1584159 - Change MixedContentBlocker to using loadInfo to pass security ancestory state

Status: RESOLVED MOVED

(Core :: DOM: Security, task, P3)

Description

[Jonathan Kingston [:jkt] he/him]

Within the MCB we have two clear paths that we block content with:

1. We check the top level frame to see if it's secure
2. If the top frame isn't secure and we are a frame, we check the ancestor chain for anything with https

In 1. we check the top level docshell for what URI it has, in a post fission world this isn't possible from a child frame.
In 2. We traverse all of the docshells and do the same, again this isn't possible.

So I propose that when a document loads we annotate the loadInfo as having a secure ancestor or not. This way we never have to traverse at all and both of these cases could be merged into one.

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: https://phabricator.services.mozilla.com/D47333

Comment 2

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1584159 - Move mixed content checks to using loadInfo

Comment 3

[Jonathan Kingston [:jkt] he/him]

The good news is that this also appears to fix issues with wpt3, wpt9 and wp10 on try.

Central:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=714c3de72e4b86a285e78c8584367f087f7dd981
With patches:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=272666359&revision=b9f95a0faa4ad48c651ce7fa342516306081deed

Comment 4

[Chris Peterson [:cpeterson]]

ckerschb says this bug is needed to fix test mixedcontentblocker/test_frameNavigation.html, so I'm moving this bug to Fission's new mochitest milestone (M4.1).

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

ckerschb says this bug is needed to fix test mixedcontentblocker/test_frameNavigation.html, so I'm moving this bug to Fission's new mochitest milestone (M4.1).

Tracking for Fission mochitests (M4.1)

Comment 6

[Chris Peterson [:cpeterson]]

Temporarily reassigning these DOM Security Fission bugs to ckerschb for re-triage.

Comment 7

[Christoph Kerschbaumer [:ckerschb}]

Turns out that this bug will be fixed by a multitude of bugs including: Bug 1575356, Bug 1629876, and Bug 1631405 (including dependencies and follow ups).

I think it makes most sense to mark this one itself as MOVED.