1584175 - .mozbuild/clang-tools/clang-tidy/bin/clang-format: error while loading shared libraries: libclang-cpp.so.9: cannot open shared object file: No such file or directory

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect, P1)

Description

[Mirko Brodesser (:mbrodesser-Igalia), offline until 10th of Feb]

$ ./mach clang-format -c HEAD
 0:00.31 Error determining the version clang-tidy/format binary, please see the attached exception: 
/home/mirko/.mozbuild/clang-tools/clang-tidy/bin/clang-format: error while loading shared libraries: libclang-cpp.so.9: cannot open shared object file: No such file or directory

 0:00.32 You're using an old version of clang-format binary. Please update to a more recent one by running: './mach bootstrap'

./mach bootstrap didn't help. Happened a few minutes ago on Ubuntu 18.04.

Comment 1

[Nathan Froyd [:froydnj]]

Did we change to clang-tidy 9.0 before we changed to clang 9.0? What's going on here?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

For a few hours, yeah
https://bugzilla.mozilla.org/show_bug.cgi?id=1583138#c3 landed "Tue, 24 Sep 2019 21:52:37""
https://bugzilla.mozilla.org/show_bug.cgi?id=1573211#c4 landed "Wed, 25 Sep 2019 21:56:53 "

But here, libclang-cpp.so.9 is a new lib, maybe not installed?

Comment 3

[Andi [:andi]]

maybe we don’t have to strip it when we build the clang-tidy package.

Comment 4

[Andi [:andi]]

Yep, this is a regression caused by bug 1573211.

Comment 5

[Andi [:andi]]

try job

Comment 6

[Andi [:andi]]

Attachment: Bug 1584175 - Add lib/libclang-cpp.* to the clang-tidy artifact. r=sylvestre

Since we've upgraded to clang 9, clang-format changed and now uses dynamic libraries
for the clang tooling lib that it uses.

Comment 7

[Nathan Froyd [:froydnj]]

(In reply to Andi-Bogdan Postelnicu [:andi] from comment #5)

try job

I'd been curious to know the size increase from not (almost) completely removing lib/.

Comment 8

[Andi [:andi]]

(In reply to Nathan Froyd [:froydnj] from comment #7)

(In reply to Andi-Bogdan Postelnicu [:andi] from comment #5)

try job

I'd been curious to know the size increase from not (almost) completely removing lib/.

That try job will tell us. Nathan please feel free to review the patch if you have time.

Comment 9

[(Away)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #2)

For a few hours, yeah
https://bugzilla.mozilla.org/show_bug.cgi?id=1583138#c3 landed "Tue, 24 Sep 2019 21:52:37""
https://bugzilla.mozilla.org/show_bug.cgi?id=1573211#c4 landed "Wed, 25 Sep 2019 21:56:53 "

But here, libclang-cpp.so.9 is a new lib, maybe not installed?

FWIW the first commit did not change any versions. It just made the clang-tidy checkers be ready for either version.

Comment 10

[Thomas Nguyen (:tnguyen)]

I am getting this error in MacOS
Error determining the version clang-tidy/format binary, please see the attached exception:
dyld: Library not loaded: @rpath/libclang-cpp.dylib
Referenced from: /Users/tnguyen/.mozbuild/clang-tools/clang-tidy/bin/clang-format
Reason: image not found

I guess that is related to this bug?

Comment 11

[Thomas Nguyen (:tnguyen)]

Ignore me plz, that got fixed after backingout bug 1573211

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2c6f2f6d173
Add lib/libclang-cpp.* to the clang-tidy artifact. r=froydnj,dmajor

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e2c6f2f6d173