Closed Bug 1584323 Opened 6 months ago Closed 6 months ago

Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations

Categories

(Core :: Storage: Quota Manager, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We need to log more object properties for fixing remaining shutdown hangs.

Attached file data-request.txt
Attachment #9096834 - Flags: data-review?(chutten)
Comment on attachment 9096834 [details]
data-request.txt

Preliminary note:

Could you please find and mention the location where we reviewed the anonymization procedure for these origin strings? That'll be useful for future data spelunkers who encounter this bug.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [CrashAnnotations.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/crashreporter/CrashAnnotations.yaml).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. This collection is also reported in crash reports, which users may opt into sending on a case by case basis.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jan Varga is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels (for "crash" pings. Default off for crash reports).

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+
Flags: needinfo?(jvarga)
Attachment #9096834 - Flags: data-review?(chutten) → data-review+

The anonymization procedure for these origin strings was introduced and reviewed first time in bug 1542478 and then in bug 1542572.

Flags: needinfo?(jvarga)
See Also: → 1542478, 1542572
Attachment #9096741 - Attachment description: Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth → Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea140aa91225
Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Comment on attachment 9096741 [details]
Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten

Beta/Release Uplift Approval Request

  • User impact if declined: Debugging information we get for fixing shutdown hangs would be limited to Nightly (and next Beta) population only.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch landed on Nightly a week ago. The size of the patch isn't small, but the patch just exposes more object properties to crash stats.
  • String changes made/needed: None
Attachment #9096741 - Flags: approval-mozilla-beta?

Comment on attachment 9096741 [details]
Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten

Better diagnostic info for these crashes SGTM.
Let's uplift for beta 14.

Attachment #9096741 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Backed out changeset 3bdc8805aea3 (Bug 1584323) for build bustages complaining about ActorsParent.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&fromchange=a465465b5d98489b8e60d6cedd71135af18b4cc7&tochange=dc6cacfca92e92193fb0ce55b0a85b3e16a5eca6&selectedJob=270591904

Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/dc6cacfca92e92193fb0ce55b0a85b3e16a5eca6

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270591904&repo=mozilla-beta&lineNumber=33482

[task 2019-10-09T23:46:49.139Z] 23:46:49 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/indexedDB'
[task 2019-10-09T23:46:49.139Z] 23:46:49 INFO - /builds/worker/fetches/clang/bin/clang++ -o ActorsParent.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/indexedDB -I/builds/worker/workspace/build/src/obj-firefox/dom/indexedDB -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/storage -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/third_party/sqlite3/src -I/builds/worker/workspace/build/src/xpcom/build -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -MD -MP -MF .deps/ActorsParent.o.pp /builds/worker/workspace/build/src/dom/indexedDB/ActorsParent.cpp
[task 2019-10-09T23:46:49.140Z] 23:46:49 ERROR - /builds/worker/workspace/build/src/dom/indexedDB/ActorsParent.cpp:16396:28: error: invalid range expression of type 'nsClassHashtable<nsCStringHashKey, mozilla::dom::indexedDB::(anonymous namespace)::DatabaseActorInfo>'; no viable 'begin' function available
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - for (const auto& entry : *gLiveDatabaseHashtable) {
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - ^ ~
[task 2019-10-09T23:46:49.140Z] 23:46:49 ERROR - /builds/worker/workspace/build/src/dom/indexedDB/ActorsParent.cpp:16911:26: error: invalid range expression of type 'const nsDataHashtable<nsStringHashKey, mozilla::dom::indexedDB::(anonymous namespace)::DatabaseMaintenance *>'; no viable 'begin' function available
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - for (const auto& entry : mDatabaseMaintenances) {
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - ^ ~~~~~~~~~~~~~~~~~~~~~
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - 2 errors generated.
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - /builds/worker/workspace/build/src/config/rules.mk:787: recipe for target 'ActorsParent.o' failed
[task 2019-10-09T23:46:49.140Z] 23:46:49 ERROR - make[4]: *** [ActorsParent.o] Error 1
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/indexedDB'
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/indexedDB/target-objects' failed
[task 2019-10-09T23:46:49.140Z] 23:46:49 ERROR - make[3]: *** [dom/indexedDB/target-objects] Error 2
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/workers'
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - dom/workers/Unified_cpp_dom_workers1.o
[task 2019-10-09T23:46:49.140Z] 23:46:49 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/workers'

Flags: needinfo?(jvarga)

Sorry, I attached a new patch that should work on Beta.

Flags: needinfo?(jvarga)
You need to log in before you can comment on or make changes to this bug.