1584362 - Crash in [@ mozilla::net::WebrtcTCPSocket::OnInputStreamReady]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-5e5a48af-a238-4934-8925-2169a0190921.

Seen while looking at nightly crash stats - macOS 10.14 crashes which started in 20190920094918: https://bit.ly/2n3kGw6

https://ome.tv/ is one URL.

Top 10 frames of crashing thread:

0 XUL mozilla::net::WebrtcTCPSocket::OnInputStreamReady media/mtransport/ipc/WebrtcTCPSocket.cpp:592
1 XUL nsPipeEvents::~nsPipeEvents xpcom/io/nsPipe3.cpp:1131
2 XUL nsPipe::OnPipeException xpcom/io/nsPipe3.cpp:964
3 XUL nsPipeOutputStream::CloseWithStatus xpcom/io/nsPipe3.cpp:1622
4 XUL nsAStreamCopier::Process xpcom/io/nsStreamUtils.cpp:342
5 XUL non-virtual thunk to nsAStreamCopier::Run xpcom/io/nsStreamUtils.cpp
6 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
7 XUL NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
8 XUL mozilla::net::nsSocketTransportService::Run netwerk/base/nsSocketTransportService2.cpp:1011
9 XUL non-virtual thunk to mozilla::net::nsSocketTransportService::Run netwerk/base/nsSocketTransportService2.cpp

Comment 1

[Byron Campen [:bwc]]

Might be fixed by bug 1583046.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Based on when this started and recent code changes, I'm calling this as a regression from bug 1569183. Feel free to update or close if comment 1 pans out.

Comment 3

[Byron Campen [:bwc]]

Not seeing this on crash-stats since bug 1583046 landed, but was very low frequency to begin with, so hard to tell right now if it is fixed yet. Will probably have to wait a week or two.

Comment 4

[Julien Cristau [:jcristau]]

Still no crashes a week later, let's call this fixed?