1583046 - Crash in [@ mozilla::net::WebrtcTCPSocket::OpenWithoutHttpProxy]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Julian Seward [:jseward]]

This bug is for crash report bp-fe032e69-2b37-4bf9-9a0a-7b2250190921.

This occurs in two different installations of the Windows nightly of 20190919094654.

Top 10 frames of crashing thread:

0 xul.dll nsresult mozilla::net::WebrtcTCPSocket::OpenWithoutHttpProxy media/mtransport/ipc/WebrtcTCPSocket.cpp:314
1 xul.dll nsresult mozilla::net::WebrtcTCPSocket::OnProxyAvailable media/mtransport/ipc/WebrtcTCPSocket.cpp
2 xul.dll static nsresult mozilla::net::nsAsyncResolveRequest::DoCallback::<unnamed-tag>::operator netwerk/base/nsProtocolProxyService.cpp:366
3 xul.dll xul.dll@0xac6995 
4 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::Finish netwerk/base/nsProtocolProxyService.cpp:599
5 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::ProcessNextFilter netwerk/base/nsProtocolProxyService.cpp:509
6 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::AsyncProcess netwerk/base/nsProtocolProxyService.cpp:485
7 xul.dll void mozilla::net::nsAsyncResolveRequest::DoCallback netwerk/base/nsProtocolProxyService.cpp:375
8 xul.dll nsresult mozilla::net::ExecuteCallback::Run netwerk/base/nsPACMan.cpp:119
9 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225

Comment 1

[Byron Campen [:bwc]]

Maybe this is another manifestation of bug 1582646?

Comment 2

[Michael Froman [:mjf]]

If Byron's thought is true in comment 1, we should see reports fall starting with the next build since the fix for Bug 1582646 just landed.

Comment 3

[Byron Campen [:bwc]]

I think I might see some additional issues stemming from the fact that the proxy lookup callback isn't happening on the thread we asked it to happen on. I'm working on a fix.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=069c517ffb11407749099f2cbebbe7b6ca10ee61

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1583046: Tighten down threading rules. r?mjf

Comment 6

[Byron Campen [:bwc]]

Try looks fine.

Comment 7

[Byron Campen [:bwc]]

Manual testing of proxy stuff (including secure-proxy) looks fine.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44cb42559383
Tighten down threading rules. r=mjf

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/44cb42559383