Closed Bug 1583046 Opened 2 years ago Closed 2 years ago

Crash in [@ mozilla::net::WebrtcTCPSocket::OpenWithoutHttpProxy]

Categories

(Core :: WebRTC: Networking, defect, P2)

Unspecified
Windows 7
defect

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- fixed

People

(Reporter: jseward, Assigned: bwc)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-fe032e69-2b37-4bf9-9a0a-7b2250190921.

This occurs in two different installations of the Windows nightly of 20190919094654.

Top 10 frames of crashing thread:

0 xul.dll nsresult mozilla::net::WebrtcTCPSocket::OpenWithoutHttpProxy media/mtransport/ipc/WebrtcTCPSocket.cpp:314
1 xul.dll nsresult mozilla::net::WebrtcTCPSocket::OnProxyAvailable media/mtransport/ipc/WebrtcTCPSocket.cpp
2 xul.dll static nsresult mozilla::net::nsAsyncResolveRequest::DoCallback::<unnamed-tag>::operator netwerk/base/nsProtocolProxyService.cpp:366
3 xul.dll xul.dll@0xac6995 
4 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::Finish netwerk/base/nsProtocolProxyService.cpp:599
5 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::ProcessNextFilter netwerk/base/nsProtocolProxyService.cpp:509
6 xul.dll nsresult mozilla::net::nsAsyncResolveRequest::AsyncApplyFilters::AsyncProcess netwerk/base/nsProtocolProxyService.cpp:485
7 xul.dll void mozilla::net::nsAsyncResolveRequest::DoCallback netwerk/base/nsProtocolProxyService.cpp:375
8 xul.dll nsresult mozilla::net::ExecuteCallback::Run netwerk/base/nsPACMan.cpp:119
9 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225

Flags: needinfo?(docfaraday)

Maybe this is another manifestation of bug 1582646?

Flags: needinfo?(docfaraday)
Component: Networking → WebRTC: Networking

If Byron's thought is true in comment 1, we should see reports fall starting with the next build since the fix for Bug 1582646 just landed.

Priority: -- → P2

I think I might see some additional issues stemming from the fact that the proxy lookup callback isn't happening on the thread we asked it to happen on. I'm working on a fix.

Assignee: nobody → docfaraday

Try looks fine.

Manual testing of proxy stuff (including secure-proxy) looks fine.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44cb42559383
Tighten down threading rules. r=mjf
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.