Closed Bug 1584479 Opened 2 months ago Closed 16 days ago

Add flag for blocked social cookies in the content blocking log

Categories

(Core :: Privacy: Anti-Tracking, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: nhnt11, Assigned: nhnt11, NeedInfo)

References

Details

Attachments

(4 files)

Bug 1576641 added STATE_COOKIES_LOADED_SOCIALTRACKER. It would be useful to have a corresponding STATE_COOKIES_BLOCKED_SOCIALTRACKER. This flag would be emitted whenever we block a third-party cookie from a social origin.

The frontend currently infers this flag by checking STATE_LOADED_SOCIALTRACKING_CONTENT && STATE_COOKIES_BLOCKED_TRACKER - but these two flags might not have been emitted for the same resource.

I talked to Ehsan about this and I'm going to try and make a patch.

Priority: -- → P5
Attachment #9096897 - Attachment description: Bug 1584479 - Use new social cookies blocked flag in protections panel category logic. r=johannh → Bug 1584479 - Part 2: Use new social cookies blocked flag in protections panel category logic. r=johannh

This change will fix bug 1580925.

The patches attached so far build successfully and SEEM to work correctly for me, but let's wait for try results [1]. Once I have the results, I expect to attach more patches to fix tests (and probably add a new one for this flag).

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0f0d846cc300f4aa6d5f2b3b2f91647b26f4f13
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=46a5c0b84edbb3297b1c8ed5223321a91918ebe7

Priority: P5 → P3

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

This change will fix bug 1580925.

The patches attached so far build successfully and SEEM to work correctly for me, but let's wait for try results [1]. Once I have the results, I expect to attach more patches to fix tests (and probably add a new one for this flag).

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0f0d846cc300f4aa6d5f2b3b2f91647b26f4f13
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=46a5c0b84edbb3297b1c8ed5223321a91918ebe7

Try shows that I missed updating an assertion somehow, and that there's one frontend social tracking test that's failing. I'll update the patch and push to try again.

Attachment #9096896 - Attachment description: Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=ehsan,baku,ewright → Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=ehsan,ewright
Attachment #9096896 - Attachment description: Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=ehsan,ewright → Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=ehsan,ewright,droeh
Attachment #9096897 - Attachment description: Bug 1584479 - Part 2: Use new social cookies blocked flag in protections panel category logic. r=johannh → Bug 1584479 - Part 3: Use new social cookies blocked flag in protections panel category logic. r=johannh
Attachment #9105791 - Attachment description: Bug 1584479 - Part 3: Update TrackingDBService test. r=ewright → Bug 1584479 - Part 4: Update TrackingDBService test. r=ewright
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7e03b392edb3
Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh
https://hg.mozilla.org/integration/autoland/rev/0edb22786545
Part 2: Update socialtracking test. r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/d2c56bd61b08
Part 3: Use new social cookies blocked flag in protections panel category logic. r=johannh,xeonchen
https://hg.mozilla.org/integration/autoland/rev/b0d9877bd8b0
Part 4: Update TrackingDBService test. r=ewright
Backout by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/070d360bafef
Backed out 4 changesets for Browser-chrome failures in toolkit/components/antitracking/test/browser/browser_socialtracking.js
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3ff3e93332d0
Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh
https://hg.mozilla.org/integration/autoland/rev/d0f91ad7450c
Part 2: Update socialtracking test. r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/8da9387aac08
Part 3: Use new social cookies blocked flag in protections panel category logic. r=johannh,xeonchen
https://hg.mozilla.org/integration/autoland/rev/16aac90f6572
Part 4: Update TrackingDBService test. r=ewright
Depends on: 1593424
Depends on: 1593509
Regressions: 1593509
You need to log in before you can comment on or make changes to this bug.