1584490 - FTP hangs when receiving 2xx response to LIST without prior 1xx response

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Christian Holler (:decoder)]

When the FTP implementation performs a LIST command and receives a 2xx response, handled by this code

https://searchfox.org/mozilla-central/rev/45f30e1d19bde27bf07e47a0a5dd0962dd27ba18/netwerk/protocol/ftp/nsFtpConnectionThread.cpp#1071

without receiving a prior 1xx response triggering this code

https://searchfox.org/mozilla-central/rev/45f30e1d19bde27bf07e47a0a5dd0962dd27ba18/netwerk/protocol/ftp/nsFtpConnectionThread.cpp#1064

then the data connection will be opened but never receive a nsInputStreamReadyEvent because AsyncWait is never called on the connection.

In testing, this leads to a hang where neither OnStartRequest nor OnStopRequest is delivered to the listener passed during asyncOpen.

The solution is to enforce reception of the 1xx code prior to switching to FTP_COMPLETE.

Comment 1

[Christian Holler (:decoder)]

Attachment: Bug 1584490 - Check for FTP LIST 1xx response before completing command. r?michal

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5591af7fd283
Check for FTP LIST 1xx response before completing command. r=michal

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5591af7fd283