1584492 - Set and propagate PIP window flag to nsWindow

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

PIP Window needs a special config on Linux so we need to provide that information to toolkit. Add it to nsWidgetInitData which propagates it to nsWindow. Special PIP window config on Linux may include:

• open window manager menu on right mouse click to place it on
  top/all workspaces (recently it's unused).
• don't use alpha blending/compositing for faster rendering
• disable titlebar shapes on X11, the window should not have round corners
• use direct rendering for video on Wayland by dmabuf surfaces

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1584492 - Add mPIPWindow to nsWidgetInitData and set it for PIP window on Linux/Gtk, r=mats

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1584492 [Linux] Add mIsPIPWindow to nsWindow, r=jhorak

Depends on D47409

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eb6fa2d58d0
Add mPIPWindow to nsWidgetInitData and set it for PIP window on Linux/Gtk, r=mats

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 7eb6fa2d58d0 (Bug 1584492) because D47410 failed to land

Backout link: https://hg.mozilla.org/integration/autoland/rev/a6da1f4067a5e0aff54231b3dec5c8aa08e7c83c

Got this when trying to land D47410:
applying /tmp/tmpn0_bV7 1 out of 1 hunk ignored -- saving rejects to file xpfe/appshell/nsAppShellService.cpp.rej 2 out of 2 hunks ignored -- saving rejects to file widget/nsWidgetInitData.h.rej abort: patch command failed: exited with status 256

Similar message when i imported the patch to manually land this.

Also clearing checkin-needed on bug 1583852 and bug 1536747 because they need these changes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/985e7a586265
Add mPIPWindow to nsWidgetInitData and set it for PIP window on Linux/Gtk, r=mats
https://hg.mozilla.org/integration/autoland/rev/061544db5126
[Linux] Add mIsPIPWindow to nsWindow, r=jhorak

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/985e7a586265
https://hg.mozilla.org/mozilla-central/rev/061544db5126