1584524 - The "No Logins" screen should offer importing logins from another browser on supporting OS

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P3)

Description

[Matthew N. [:MattN]]

Users may not know that the import option exists in the meatball menu so the "no logins" screen seems like a great place to suggest and link to import (along with Sync if not already setup) to allow the user to import their passwords from another browser.

We may also want to consider a promo footer for import for users with only a few logins.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Betsy, can you provide some copy that we can use for the No Logins screen to include a link to the Import dialog?

Comment 2

[rgaddis]

Collaborated on an approach with Betsy. We'll need to account for the import string in both cases (signed in, 0 logins, signed out, 0 logins, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1572464)

New String: If your logins are saved in another browser, you can import them into Lockwise

Design: https://zpl.io/bWXoxm1

Comment 3

[rgaddis]

Attachment: Lockwise Desktop - No Logins Found, not signed in.png

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

We currently only support importing logins from other browsers. What do you have in mind by the "or format" part of the string?

Comment 5

[rgaddis]

Attachment: Lockwise Desktop - No Logins Found, not signed in.png

Comment 6

[rgaddis]

Updated string: If your logins are saved in another browser, you can import them into Lockwise

We'll revisit this string when additional formats for importing are actually available (within the wizard)

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1584524 - Show an Import link on the login-intro view of about:logins. r?MattN

Comment 8

[Matthew N. [:MattN]]

We also don't support importing on Linux so I suggested we hide this line there.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/004bfb67bff4
Show an Import link on the login-intro view of about:logins. r=MattN,fluent-reviewers

Comment 10

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=272192953&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=004bfb67bff4797b4625c5797890f6e8b50c1245&searchStr=browser%2Cchrome%2C

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=272192953&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/63a558f063ab80a06cb140606bb50e33d54ec8cf

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eadf47e498ff
Show an Import link on the login-intro view of about:logins. r=MattN,fluent-reviewers

Comment 12

[Oana Pop-Rus]

Backed out 2 changesets (bug 1571425, bug 1584524) for bc perma failures in browser_noLoginsView.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&duplicate_jobs=visible&resultStatus=success%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-3%2Cm%28bc3%29&fromchange=3d7b77564cb7ca0800deedbb46de66a8b630d1f6&tochange=cdd02235e1cad3984bab1112c22a2771b2119608&selectedJob=272645996

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272645996&repo=autoland&lineNumber=4184

Backout: https://hg.mozilla.org/integration/autoland/rev/12c55d177a9ff5bed2ea1a049cbf794905267823

Comment 13

[Sam Foster [:sfoster] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2553b8b6dd110f4fb9bbc7641ec0740a503d7f0c

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e44ec82f92c9
Show an Import link on the login-intro view of about:logins. r=MattN,fluent-reviewers

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e44ec82f92c9

Comment 16

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 72.0a1 (Build ID: 20191028094851) on Windows 10 x64, Mac 10.14.

• The “If your logins are saved in another browser, you can import them into Lockwise” option is added on the “No synced logins found.” screen, where “import them into Lockwise” string is a link.
• When click on the link, the “Import Wizard” pop-up is displayed.