1584625 - browser_aboutwelcome.js mochitest fails when run twice

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

Attachment: RTAMO welcome screen

STR:

1. On latest master run npm run mochitest twice. First successfully passes test
2. Running 'npm run mochitest' again fails with below error:

browser/components/newtab/test/browser/browser_aboutwelcome.js
FAIL Uncaught exception - Should render .trailhead.joinCohort in the join-privacy branch - timed out after 50 tries.
FAIL Found an unexpected tab at the end of test run: about:welcome -

Running local nightly and opening about:welcome shows RTAMO welcome ( See attached)

Comment 1

[Punam Dahiya [:pdahiya]]

Looks like mochitest is forcing the browser to set some attribution parameters for testing the Return To AMO feature which are not getting cleared after test completes.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5329

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5340

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9d2586266fcd