1584649 - Small Standalone Bytecode Emitter Cleanups around GC thing requirements.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1584649 - Eliminate function requirement in BytecodeEmitter::emitFunction r?tcampbell

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1584649 - Support putting field initializers inside the LazyScriptCreationData

Note, the deferred code paths are unused until we move publication -after- bytecode emission

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95fa040657ec
Support putting field initializers inside the LazyScriptCreationData r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7414831ed19d
Eliminate function requirement in BytecodeEmitter::emitFunction r=tcampbell

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/95fa040657ec
https://hg.mozilla.org/mozilla-central/rev/7414831ed19d

Comment 5

[Ted Campbell [:tcampbell]]

I've ended up putting the 'fun' back in Bug 1583816 to get Part 1 landed. It requires the function when the JSScript is first created rather than when add the scopes to the JSScript.

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1584649 - Remove un-needed template parameter in EmitterScope r?tcampbell

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82d9a4a318b3
Remove un-needed template parameter in EmitterScope r=tcampbell

Comment 8

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1584649 - Provide bytecode compiler with access to the ParseInfo r?tcampbell

This is subsequently used to allow BytecodeEmitter access to the ParseInfo,
so that the BytecodeEmitter can decide the vary its behviour depending on
the ParseInfo.

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1584649 - Provide Bytecode Emitter access to ParseInfo r?tcampbell

This allows the bytecode emitter to vary its code paths depending on whether
or not we are deferring GC object allocation.

Depends on D51010

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/82d9a4a318b3

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a8bbfa8377b
Provide bytecode compiler with access to the ParseInfo r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ae7a806fdd91
Provide Bytecode Emitter access to ParseInfo r=tcampbell

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1a8bbfa8377b
https://hg.mozilla.org/mozilla-central/rev/ae7a806fdd91

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82d9a4a318b3

Comment 14

[Matthew Gaudet (he/him) [:mgaudet]]

Closing this one, will open a new bug if I find new fixes.