1584697 - Accounts dialog visual glitches

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Teodor]

Attachment: tb68_glitches.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Clean new install of 68.1.0, also updated yesterday to 68.1.1. Windows Server 2016 or Win10. Old TBs don't suffer from the bugs here.
No add-ons (disabled Lightning), no custom themes, nothing.
Two aggravating and dangerous visual glitches in at least Accounts settings dialog.

Open the Accounts setup dialog window and select an account's Server settings page.

Actual results:

The Username field, while wide enough (visually), its content is cut off somewhere in the middle and the rest of the username is not visible and it can be misleading and wrongly identified as a wrong or incomplete username.
The same is true for the SMTP settings page where the informational fields are also "internally" cut off and longer contents are cut off somewhere in the middle of the field.

Some pages in the Accounts dialog cause horizontal scrollbar to appear while not really necessary as they reveal only empty space on the right.

Expected results:

The actual Username fields' contents should be visible as long as there is space in the field to its full width. The same for SMTP settings' server's info area.

Also pages like "Copies & Folders" should not have scrollbars.

Comment 1

[Teodor]

Attachment: tb68_glitches.png

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks for reporting. Yes, I can see the scrollbar in the "Copies & Folders", but I can't see a user name or SMTP details being cut off anywhere. Hold on, you mean the info1@test123test123.c where the "om" is missing, I got it. Can you please supply an additional screenshot for the cut off SMTP details.

Richard, can we please look into this.

Comment 3

[Richard Marti (:Paenglab)]

This is Windows only and has something to do with the .folderMenuItem (the menulists with the folder icons in them). I need to look why they use more space than we see. The same happens in filter create dialog when a folderMenuItem is visible. Then the scrollbar is shown.

Comment 4

[Teodor]

Attachment: tb68_smtp.png

As seen in the screenshot for SMTP area, there is a "m" hidden from .com in the username.
Also, for Authentication Method it says: "Password, transmitted", where "insecurely is not visible - it can be seen if I click on the label/text itself and hit "End" button on the keyboard.

Comment 5

[Jorg K (CEST = GMT+2)]

Thanks. Richard, more stuff to look at.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1584697-no-moz-image-region-dropmarker.patch

I've chosen folderMenus.css because wherever the icons are applied the dropmarker gets the image too (also when it doesn't show the image is reserves the space on the right which makes the usage of more space.

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Teodor from comment #4)

Created attachment 9097109 [details]
tb68_smtp.png

As seen in the screenshot for SMTP area, there is a "m" hidden from .com in the username.
Also, for Authentication Method it says: "Password, transmitted", where "insecurely is not visible - it can be seen if I click on the label/text itself and hit "End" button on the keyboard.

We do only one issue per bug. Please could you file a new bug for this issue?

Comment 8

[Teodor]

Jorg K asked for this additional SMTP screenshot. Also I believe they are the same (or related) bug(s) - labels are cut off while there is plenty of space in the "parent" container.

Comment 9

[Jorg K (CEST = GMT+2)]

We do only one issue per bug. Please could you file a new bug for this issue?

Let's do this here in a "part 2", OK? We're fixing visual issues in the AM, that's the bug ;-)

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1584697-SMTP-field-width.patch

Okay, here is part 2 for the SMTP info field.

Comment 11

[Jorg K (CEST = GMT+2)]

And comment #2, the missing "om"?

Comment 12

[Richard Marti (:Paenglab)]

This would be part 3 ;-) , but I don't see this. Do you?

Comment 13

[Jorg K (CEST = GMT+2)]

Not where I am right now using Android ;-) - try a long email address and switch panes. Hard to understand since there is enough space in the box.

Comment 14

[Richard Marti (:Paenglab)]

Tried, don't see it.

Comment 15

[Jorg K (CEST = GMT+2)]

Comment on attachment 9097111 [details] [diff] [review]
1584697-no-moz-image-region-dropmarker.patch

This miraculously gets rid of the horizontal scrollbar. The Swiss master at work :-)

Comment 16

[Jorg K (CEST = GMT+2)]

Comment on attachment 9097135 [details] [diff] [review]
1584697-SMTP-field-width.patch

This works, too. I'll fix the typo in the commit message.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1c185647609b
Don't apply the -moz-image-region to the dropmarker to not virtually extent the menulist. r=jorgk
https://hg.mozilla.org/comm-central/rev/20f327d46fb9
Let the values in the serverInfoBox use the whole width. r=jorgk

Comment 18

[Jorg K (CEST = GMT+2)]

TB 70 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/f88fe6789a40e9162fa2a6a89510a86bb7d70870
https://hg.mozilla.org/releases/comm-beta/rev/c64177c02dce3637c6ea83038bd0437299c7a08a

Comment 19

[Jorg K (CEST = GMT+2)]

TB 68.1.2 or TB 68.2:
https://hg.mozilla.org/releases/comm-esr68/rev/786073dcb3052a788c29ab438a196b4aa6fb7906
https://hg.mozilla.org/releases/comm-esr68/rev/809f74a95d166ce7b7c87b2915f6dc79de2608f0