1584790 - [PIP/Linux] White strips are drawn by video side in CSD mode

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

When PIP window has a wrong size white strips are painted by video.

We can't entirely avoid the situation when the white strips are painted, for instance when window manager resizes the window in tilling mode, but we can draw black background there at least.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

The white strips are painted by compositor, not by Gtk.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

There's an issue with CSD client decorations - aspect ratio for window lock is not calculated accurately. It's visible under Wayland and when CSD mode is used in X11.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1584790 - [Linux] De-scale window size when calculating aspect ratio, r=jhorak

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Filed as https://gitlab.gnome.org/GNOME/gtk/issues/2189

Comment 5

[Martin Stránský [:stransky] (ni? me)]

That's Gtk CSD error and we can only workaround it.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

This is only partial fix and works when PIP window is not radically resized. For proper fix we need to wait to https://gitlab.gnome.org/GNOME/gtk/issues/2189

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d0ff856543c
[Linux] De-scale window size when calculating aspect ratio, r=jhorak

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3d0ff856543c