1584935 - Enable lazy frame construction from XUL elements.

Status: RESOLVED FIXED

(Core :: XUL, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

That is, make this function always return true.

This would allow to simplify a bit the layout code, and avoid nasty bugs like bug 1575138.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1584935 - [wip] Enable lazy frame construction for XUL.

Just don't want to lose track of this.

Comment 2

[Brian Grinstead [:bgrins]]

I did a try push earlier today (before Bug 1591297 landed, if that's relevant). And there are at least some green chunks now, but still a lot of orange: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b30733f37f430223d714e7f1c5f3c55f1cfda6da&group_state=expanded

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This looks much closer... https://treeherder.mozilla.org/#/jobs?repo=try&revision=24bc39e0a54ad6d64fcd56385eaeb08e43195286

I'll try to figure out the remaining bits tomorrow / next week.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1584935 - Enable lazy frame construction everywhere. r=tnikkel

This is only the minimal change, there's cleanup coming afterwards in
follow-up bugs.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1584935 - Clean up a tiny bit more now that lazyfc is infallible. r=tnikkel

Fairly minor clean-up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d7c5732cda9
Enable lazy frame construction everywhere. r=tnikkel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e78fc5cb2ed7
Clean up a tiny bit more now that lazyfc is infallible. r=tnikkel

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 2 changesets (bug 1584935) for many toolkit/content/tests/chrome/test_* failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C7%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-windows7-32%2Fdebug-mochitest-chrome-1proc-3%2Cm-1proc%28c3%29&fromchange=eaadf10e4478b4480f24dadf51eb5893d2888b05&tochange=f728629fde6adb3599e73fa7652812f0e0138061&selectedTaskRun=Hy0Lb1jaR3KutsQAgXRlmg-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/f728629fde6adb3599e73fa7652812f0e0138061

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301813949&repo=autoland&lineNumber=12807

[task 2020-05-11T23:28:17.528Z] 23:28:17     INFO - TEST-START | toolkit/content/tests/chrome/test_popup_attribute.xhtml
[task 2020-05-11T23:28:17.823Z] 23:28:17     INFO - GECKO(4440) | [Parent 4932, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4285
[task 2020-05-11T23:28:18.690Z] 23:28:18     INFO - GECKO(4440) | [Parent 4932, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp, line 3734
[task 2020-05-11T23:28:18.725Z] 23:28:18     INFO - GECKO(4440) | [Parent 4932, Main Thread] WARNING: NS_ENSURE_TRUE(presShell) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4283
[task 2020-05-11T23:28:21.605Z] 23:28:21     INFO - GECKO(4440) | [Parent 4932, Main Thread] WARNING: '!mPresContext', file /builds/worker/checkouts/gecko/dom/events/UIEvent.cpp, line 137
[task 2020-05-11T23:28:21.805Z] 23:28:21     INFO - GECKO(4440) | [Parent 4932, Main Thread] WARNING: '!mPresContext', file /builds/worker/checkouts/gecko/dom/events/UIEvent.cpp, line 137
[task 2020-05-11T23:28:21.900Z] 23:28:21     INFO - TEST-INFO | started process screenshot
[task 2020-05-11T23:28:21.963Z] 23:28:21     INFO - TEST-INFO | screenshot: exit 0
[task 2020-05-11T23:28:21.963Z] 23:28:21     INFO - <snipped 993 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
[task 2020-05-11T23:28:21.964Z] 23:28:21     INFO - Buffered messages logged at 23:28:21
[task 2020-05-11T23:28:21.965Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with override end_after position 
[task 2020-05-11T23:28:21.965Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape event type popuphiding fired 
[task 2020-05-11T23:28:21.965Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape event target ID thepopup 
[task 2020-05-11T23:28:21.966Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape popuphiding state 
[task 2020-05-11T23:28:21.966Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape event type popuphidden fired 
[task 2020-05-11T23:28:21.966Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape event target ID thepopup 
[task 2020-05-11T23:28:21.967Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape popuphidden state 
[task 2020-05-11T23:28:21.967Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape event type DOMMenuInactive fired 
[task 2020-05-11T23:28:21.967Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | close popup with escape event target ID thepopup 
[task 2020-05-11T23:28:21.968Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets event type popupshowing fired 
[task 2020-05-11T23:28:21.968Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets event target ID thepopup 
[task 2020-05-11T23:28:21.968Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets popupshowing state 
[task 2020-05-11T23:28:21.968Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets event type popupshown fired 
[task 2020-05-11T23:28:21.969Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets event target ID thepopup 
[task 2020-05-11T23:28:21.969Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets popupshown state 
[task 2020-05-11T23:28:21.969Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets before_start width 
[task 2020-05-11T23:28:21.970Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets before_start height 
[task 2020-05-11T23:28:21.970Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup anchored with offsets before_start position 
[task 2020-05-11T23:28:21.970Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup unanchored event type popupshowing fired 
[task 2020-05-11T23:28:21.971Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup unanchored event target ID thepopup 
[task 2020-05-11T23:28:21.971Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup unanchored popupshowing state 
[task 2020-05-11T23:28:21.971Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup unanchored event type popupshown fired 
[task 2020-05-11T23:28:21.972Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup unanchored event target ID thepopup 
[task 2020-05-11T23:28:21.972Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup unanchored popupshown state 
[task 2020-05-11T23:28:21.972Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup unanchored 
[task 2020-05-11T23:28:21.973Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event type DOMMenuInactive fired 
[task 2020-05-11T23:28:21.973Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event target ID thepopup 
[task 2020-05-11T23:28:21.973Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event type command fired 
[task 2020-05-11T23:28:21.973Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event target ID item3 
[task 2020-05-11T23:28:21.973Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event type popuphiding fired 
[task 2020-05-11T23:28:21.974Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event target ID thepopup 
[task 2020-05-11T23:28:21.974Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse popuphiding state 
[task 2020-05-11T23:28:21.974Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event type popuphidden fired 
[task 2020-05-11T23:28:21.975Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event target ID thepopup 
[task 2020-05-11T23:28:21.975Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse popuphidden state 
[task 2020-05-11T23:28:21.975Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event type DOMMenuItemInactive fired 
[task 2020-05-11T23:28:21.976Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | activate menuitem with mouse event target ID item3 
[task 2020-05-11T23:28:21.976Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen event type popupshowing fired 
[task 2020-05-11T23:28:21.976Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen event target ID thepopup 
[task 2020-05-11T23:28:21.977Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen popupshowing triggerNode 
[task 2020-05-11T23:28:21.977Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen popupshowing document.popupNode 
[task 2020-05-11T23:28:21.977Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen popupshowing document.tooltipNode 
[task 2020-05-11T23:28:21.977Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen popupshowing state 
[task 2020-05-11T23:28:21.978Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen event type popupshown fired 
[task 2020-05-11T23:28:21.978Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen event target ID thepopup 
[task 2020-05-11T23:28:21.978Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen popupshown state 
[task 2020-05-11T23:28:21.978Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen anchorNode 
[task 2020-05-11T23:28:21.979Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen triggerNode 
[task 2020-05-11T23:28:21.979Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen document.popupNode 
[task 2020-05-11T23:28:21.979Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen left 
[task 2020-05-11T23:28:21.980Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen top 
[task 2020-05-11T23:28:21.980Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen right is 184.0833282470703 
[task 2020-05-11T23:28:21.980Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open popup at screen bottom is 246 
[task 2020-05-11T23:28:21.981Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event type DOMMenuItemActive fired 
[task 2020-05-11T23:28:21.981Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event target ID amenu 
[task 2020-05-11T23:28:21.981Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event type DOMMenuItemInactive fired 
[task 2020-05-11T23:28:21.981Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event target ID amenu 
[task 2020-05-11T23:28:21.982Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event type DOMMenuInactive fired 
[task 2020-05-11T23:28:21.982Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event target ID thepopup 
[task 2020-05-11T23:28:21.982Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event type command fired 
[task 2020-05-11T23:28:21.983Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event target ID amenu 
[task 2020-05-11T23:28:21.983Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event type popuphiding fired 
[task 2020-05-11T23:28:21.983Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event target ID thepopup 
[task 2020-05-11T23:28:21.983Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator popuphiding state 
[task 2020-05-11T23:28:21.984Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event type popuphidden fired 
[task 2020-05-11T23:28:21.984Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event target ID thepopup 
[task 2020-05-11T23:28:21.984Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator popuphidden state 
[task 2020-05-11T23:28:21.985Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event type DOMMenuItemInactive fired 
[task 2020-05-11T23:28:21.985Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem accelerator event target ID amenu 
[task 2020-05-11T23:28:21.985Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen event type popupshowing fired 
[task 2020-05-11T23:28:21.986Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen event target ID thepopup 
[task 2020-05-11T23:28:21.986Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen modifiers mask matches 
[task 2020-05-11T23:28:21.986Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen popupshowing triggerNode 
[task 2020-05-11T23:28:21.986Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen popupshowing document.popupNode 
[task 2020-05-11T23:28:21.987Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen popupshowing document.tooltipNode 
[task 2020-05-11T23:28:21.987Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen popupshowing state 
[task 2020-05-11T23:28:21.987Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen event type popupshown fired 
[task 2020-05-11T23:28:21.988Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen event target ID thepopup 
[task 2020-05-11T23:28:21.988Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen popupshown state 
[task 2020-05-11T23:28:21.988Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen anchorNode 
[task 2020-05-11T23:28:21.989Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen triggerNode 
[task 2020-05-11T23:28:21.989Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen document.popupNode 
[task 2020-05-11T23:28:21.989Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | cannot get popupNode from other document 
[task 2020-05-11T23:28:21.990Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | cannot get popupNode from other document 
[task 2020-05-11T23:28:21.990Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen left 
[task 2020-05-11T23:28:21.990Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen top 
[task 2020-05-11T23:28:21.990Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen right is 170.0833282470703 
[task 2020-05-11T23:28:21.991Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open context popup at screen bottom is 244 
[task 2020-05-11T23:28:21.991Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator event type DOMMenuItemActive fired 
[task 2020-05-11T23:28:21.991Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator event target ID one 
[task 2020-05-11T23:28:21.992Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator item one active 
[task 2020-05-11T23:28:21.992Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator again event type DOMMenuItemInactive fired 
[task 2020-05-11T23:28:21.992Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator again event target ID one 
[task 2020-05-11T23:28:21.992Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator again event type DOMMenuItemActive fired 
[task 2020-05-11T23:28:21.993Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator again event target ID submenu 
[task 2020-05-11T23:28:21.993Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator again submenu menu is open 
[task 2020-05-11T23:28:21.993Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | menuitem with non accelerator again item submenu active 
[task 2020-05-11T23:28:21.994Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open submenu with cursor right event type popupshowing fired 
[task 2020-05-11T23:28:21.994Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open submenu with cursor right event target ID submenupopup 
[task 2020-05-11T23:28:21.994Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open submenu with cursor right popupshowing state 
[task 2020-05-11T23:28:21.994Z] 23:28:21     INFO - Buffered messages finished
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open submenu with cursor right event type popupshown fired - got "popupshown", expected "DOMMenuItemActive"
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:383:14
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - is@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_shared.js:83:30
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - eventOccurred@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_shared.js:143:9
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - EventListener.handleEvent*startPopupTests@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_shared.js:44:12
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - runTests@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_trigger.js:50:18
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open submenu with cursor right event target ID submenupopup - got "submenupopup", expected "submenuitem"
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:383:14
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - is@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_shared.js:83:30
[task 2020-05-11T23:28:21.995Z] 23:28:21     INFO - eventOccurred@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_shared.js:148:9
[task 2020-05-11T23:28:21.996Z] 23:28:21     INFO - EventListener.handleEvent*startPopupTests@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_shared.js:44:12
[task 2020-05-11T23:28:21.996Z] 23:28:21     INFO - runTests@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/popup_trigger.js:50:18
[task 2020-05-11T23:28:21.996Z] 23:28:21     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-05-11T23:28:21.996Z] 23:28:21     INFO - TEST-PASS | toolkit/content/tests/chrome/test_popup_attribute.xhtml | open submenu with cursor right popupshown state 
[task 2020-05-11T23:29:50.671Z] 23:29:50     INFO -  [4544, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/components/places/Database.cpp, line 544
[task 2020-05-11T23:29:50.671Z] 23:29:50     INFO -  [4544, Main Thread] WARNING: Unable to get a connection to vacuum database: file /builds/worker/checkouts/gecko/storage/VacuumManager.cpp, line 128
[task 2020-05-11T23:29:50.726Z] 23:29:50     INFO -  [4544, IPDL Background] WARNING: '!gBasePath', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp, line 3627
[task 2020-05-11T23:29:50.726Z] 23:29:50     INFO -  [4544, IPDL Background] WARNING: profile-do-change must precede QuotaManager::GetOrCreate(): file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp, line 3628
[task 2020-05-11T23:29:50.726Z] 23:29:50     INFO -  [4544, IPDL Background] WARNING: '!quotaManager', file /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp, line 8595
[task 2020-05-11T23:29:56.681Z] 23:29:56     INFO - GECKO(4440) | [Parent 4932, Jump List] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/widget/windows/WinUtils.cpp, line 1353
[task 2020-05-11T23:31:56.714Z] 23:31:56     INFO - GECKO(4440) | [Parent 4932, Jump List] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /builds/worker/checkouts/gecko/widget/windows/WinUtils.cpp, line 1353
[task 2020-05-11T23:33:29.670Z] 23:33:29     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_popup_attribute.xhtml | Test timed out. 
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:299:16
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:128:22
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:150:18
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.673Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.674Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.674Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.674Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
[task 2020-05-11T23:33:29.674Z] 23:33:29     INFO - setTimeout handler*TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:184:15
...
...
...

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Also seeing these failures starting with the backed out changes:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=MqCSHql3QlKIoherF_yCGg-0&fromchange=eaadf10e4478b4480f24dadf51eb5893d2888b05&searchStr=windows%2C7%2Cdebug%2Cmochitests%2Ctest-windows7-32%2Fdebug-mochitest-browser-chrome-e10s-5%2Cm%28bc5%29&tochange=f728629fde6adb3599e73fa7652812f0e0138061

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301813955&repo=autoland&lineNumber=6071

https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Op2yW8GWQuyorKGH3IfaDA-0&fromchange=eaadf10e4478b4480f24dadf51eb5893d2888b05&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux1804-64-shippable%2Fopt-mochitest-a11y-1proc%2Cm-1proc%28a11y%29&tochange=f728629fde6adb3599e73fa7652812f0e0138061

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301825662&repo=autoland&lineNumber=2404

https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=F_EjcSLOQrOSe3Zx7FDrHQ-0&fromchange=eaadf10e4478b4480f24dadf51eb5893d2888b05&searchStr=linux%2C18.04%2Cx64%2Cquantumrender%2Cshippable%2Copt%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux1804-64-shippable-qr%2Fopt-mochitest-chrome-1proc-2%2Cm-1proc%28c2%29&tochange=f728629fde6adb3599e73fa7652812f0e0138061

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301825657&repo=autoland&lineNumber=4661

https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=I8oh5mrVT3G0n3FaPu2_Pg-0&fromchange=eaadf10e4478b4480f24dadf51eb5893d2888b05&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s-7%2Cm%28bc7%29&tochange=f728629fde6adb3599e73fa7652812f0e0138061

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301820039&repo=autoland&lineNumber=2276

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28e2781f3026
Enable lazy frame construction everywhere. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/91e7137acba3
Clean up a tiny bit more now that lazyfc is infallible. r=tnikkel

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/28e2781f3026
https://hg.mozilla.org/mozilla-central/rev/91e7137acba3

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out for accessibility failures on e.g. accessible/tests/mochitest/tree/test_tabbrowser.xhtml

backout: https://hg.mozilla.org/integration/autoland/rev/16456971c2e6269f70496d8f6c71e90e02c522e8

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2C18.04%2Cx64%2Cquantumrender%2Cshippable%2Copt%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux1804-64-shippable-qr%2Fopt-mochitest-a11y-1proc%2Cm-1proc%28a11y%29&tochange=4729e4a1fe6ccb098c69c0e99082c9f68d6b0a07&fromchange=be02f68833f2b2d97dddcc2f09d90fb7028be215&selectedTaskRun=WIniKi2JS2usJiWYp6HgAA-0

failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302058077&repo=autoland&lineNumber=3076 -> accessible/tests/mochitest/relations/test_tabbrowser.xhtml | Test timed out.
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302059957&repo=autoland&lineNumber=2714 -> accessible/tests/mochitest/events/test_scroll.xhtml | Test timed out.
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302059974&repo=autoland&lineNumber=3561 -> accessible/tests/mochitest/tree/test_tabbrowser.xhtml | Test timed out.

Comment 13

[Natalia Csoregi [:nataliaCs]]

Backout merged to mozilla-central: https://hg.mozilla.org/mozilla-central/rev/16456971c2e6269f70496d8f6c71e90e02c522e8

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4710420a731b
Enable lazy frame construction everywhere. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/7393414ac975
Clean up a tiny bit more now that lazyfc is infallible. r=tnikkel

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4710420a731b
https://hg.mozilla.org/mozilla-central/rev/7393414ac975