1637459 - Intermittent browser/components/uitour/test/browser_UITour2.js | Menu should be visible after showMenu() -

Status: RESOLVED FIXED

(Firefox :: Tours, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=302006658&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Gj9Usg0wRkutQPIZRLjiqQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-05-12T23:27:33.988Z] 23:27:33 INFO - TEST-START | browser/components/uitour/test/browser_UITour2.js
[task 2020-05-12T23:27:39.754Z] 23:27:39 INFO - TEST-PASS | browser/components/uitour/test/browser_UITour2.js | The panel shouldn't have @panelopen -
[task 2020-05-12T23:27:39.754Z] 23:27:39 INFO - TEST-PASS | browser/components/uitour/test/browser_UITour2.js | The panel shouldn't be open -
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - TEST-PASS | browser/components/uitour/test/browser_UITour2.js | Menu button should know that the menu is closed -
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - Done shared checks
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - Starting
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - test_bookmarks_menu
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - TEST-PASS | browser/components/uitour/test/browser_UITour2.js | Menu should initially be closed -
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - Buffered messages finished
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_UITour2.js | Menu should be visible after showMenu() -
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - Stack trace:
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - chrome://mochitests/content/browser/browser/components/uitour/test/head.js:taskify/</<:61
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - promise callbackchrome://mochitests/content/browser/browser/components/uitour/test/head.js:taskify/<:60
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - chrome://mochitests/content/browser/browser/components/uitour/test/head.js:nextTest/</<:546
[task 2020-05-12T23:27:39.755Z] 23:27:39 INFO - setTimeout handlerchrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest_setTimeoutShim:788
[task 2020-05-12T23:27:39.756Z] 23:27:39 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:waitTest:1045
[task 2020-05-12T23:27:39.756Z] 23:27:39 INFO - MessageListener.receiveMessagechrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus:1037
[task 2020-05-12T23:27:39.756Z] 23:27:39 INFO - chrome://mochikit/content/browser-test.js:test_waitForFocus:1393
[task 2020-05-12T23:27:39.756Z] 23:27:39 INFO - chrome://mochitests/content/browser/browser/components/uitour/test/head.js:loadUITourTestPage/<:441
[task 2020-05-12T23:27:39.756Z] 23:27:39 INFO - JSActor queryresource://testing-common/BrowserTestUtilsChild.jsm:handleEvent:265
[task 2020-05-12T23:27:39.756Z] 23:27:39 INFO - == Done test, doing shared checks before teardown ==

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Has stopped after bug 1584935 got backed out.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Ack, will try to make sure this is fixed before relanding that. Closing for now. Please ni? if it shows up again due to my change :)

Comment 3

[Intermittent Failures Robot]

50 failures in 1048 pushes (0.048 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 32
• mozilla-central: 9
• try: 9

Platform breakdown:

• windows10-64-qr: 7
• macosx1014-64-shippable: 12
• windows7-32-shippable: 6
• windows10-64-shippable-qr: 6
• windows10-64-shippable: 3
• linux1804-64: 4
• windows7-32: 4
• windows10-64: 4
• linux1804-64-shippable: 2
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1637459&startday=2020-05-13&endday=2020-05-13&tree=all

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Let's reopen to land the fix.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1637459 - Make nsXULElement::HasMenu flush frames. r=smaug,tnikkel

The UITour code assumes that it will return the up-to-date value, which
doesn't happen with lazy frame construction.

This is used sparingly in the front end code, so it doesn't quite
warrant more optimization.

Comment 6

[Intermittent Failures Robot]

65 failures in 5488 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

This is the #20 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 47
• mozilla-central: 9
• try: 9

Platform breakdown:

• windows10-64-qr: 9
• windows10-64: 5
• macosx1014-64-shippable: 21
• windows10-64-shippable-qr: 7
• windows10-64-shippable: 4
• windows7-32-shippable: 7
• linux1804-64: 4
• windows7-32: 4
• linux1804-64-shippable: 2
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1637459&startday=2020-05-11&endday=2020-05-17&tree=all

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5de26330b54
Make nsXULElement::HasMenu flush frames. r=tnikkel

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d5de26330b54

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1584935