1585224 - Cache calUtils get*Service calls to reduce XPCOM overhead

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Every time we ask calUtils for a service, it goes to XPCOM and asks to getService(). This is expensive, and we do it a lot. Since services are singletons that don't change, we should only do it once and remember the result.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1585224-cache-getservice-1.diff

Comment 2

[Wayne Mery (:wsmwk)]

This is expensive, and we do it a lot.

In what places/actions do you expect users to notice/see improvement - startup for example?

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 9097555 [details] [diff] [review]
1585224-cache-getservice-1.diff

Review of attachment 9097555 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/modules/calUtils.jsm
@@ +20,5 @@
>  
> +// Cache services to avoid calling getService over and over again. The cache is
> +// a separate object to avoid polluting `cal`, and is defined here since a call
> +// to `_service` will require it to already exist.
> +var ServiceCache = {};

gServiceCache

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b3b5a9cd7a32
Cache calUtils getService calls; r=Fallen