1759768 - Change calUtils service getters into properties

Status: RESOLVED FIXED

(Calendar :: Internal Components, enhancement)

Description

[Geoff Lankow (:darktrojan)]

The cal object has a bunch of methods for getting services. They're called like this: cal.getCalendarManager() or cal.getWeekInfoService() but having them as methods really isn't necessary, they could just be referenced as cal.manager or cal.weekInfoService.

To do this we should get rid of the _service function that implements the methods, and just call XPCOMUtils.defineLazyServiceGetter to add them to cal. Then go around and change all of the callers, which should be a simple find/replace operation.

(Later on, we can get rid of the interfaces calICalendarManager, calIFreeBusyService, and calIWeekInfoService altogether and just reference the objects straight from the modules. And nsIDragService doesn't really need to be here at all. But I think these are things for another bug.)

Comment 1

[Sean Burke [:leftmostcat]]

Attachment: Bug 1759768 - use standard lazy getters for cal services. r=darktrojan

Comment 2

[Sean Burke [:leftmostcat]]

Attachment: Bug 1759768 - remove misplaced Java modelines. r=#thunderbird-reviewers

Depends on D141897

Comment 3

[Phabricator Automation]

Comment on attachment 9269127 [details]
Bug 1759768 - remove misplaced Java modelines. r=#thunderbird-reviewers

Revision D141898 was moved to bug 1761129. Setting attachment 9269127 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/745eeaff881c
use standard lazy getters for cal services. r=darktrojan