1585315 - [FxA] Incorrect notification is received when Resending Verification

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, defect, P1)

Description

[Ioana Rusiczki]

Attachment: Verify your account notification.gif

STR:
Affected versions
Tested on FF Nightly 71.0a1

Affected platforms:
Tested on Windows 10x86

STR:

1. On a new profile click on the FxA toolbar menu button and create a new account.
2. When you reach "Confirm your account" page - don't go to confirm it in the e-mail.
3. Click the Hamburger Menu and you will notice the "Finish Account Setup" yellow warning.
4. You will be redirected to about:preferences?entrypoint=fxa_app_menu#sync
5. Click on Resend Verification and check the notification on the bottom right side of the screen

Expected result:
The notification announces that the verification was resent.

Actual result:
"Unable to send Verification" is displayed.

Notes:
Please note that the verification is received on e-mail. Only the notification is incorrect.
This issue is not reproducible on FF69 or FF70b9.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

ouch - bug 1574048 must have changed the world such that fxAccounts.getSignedInUser() previously didn't need a this but now does :( I can't see anywhere else that makes this assumption, so I'll just fix this one case.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1585315 - correctly handle FxA verification mail resend request. r?lina

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56c3c1c5edd6
correctly handle FxA verification mail resend request. r=lina

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/56c3c1c5edd6

Comment 5

[Ioana Rusiczki]

Attachment: verified fixed 71.gif

I verified this issue on FF71 (Win10) and it is no longer reproducible.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Ioana Rusiczki from comment #5)

I verified this issue on FF71 (Win10) and it is no longer reproducible.

Thanks!