Closed
Bug 1585364
Opened 5 years ago
Closed 5 years ago
IsFrame check isn't working for fission
Categories
(Core :: DOM: Security, defect, P2)
Core
DOM: Security
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jkt, Assigned: jkt)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
https://searchfox.org/mozilla-central/rev/23f836a71cfe961373c8bd0d0219ec60a64b3c8f/dom/base/nsFrameLoader.cpp#2133-2138 doesn't work post fission and so our cross origin iframes are considered as documents which will break most of our security checks.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
It actually seems like this happens before the fission splits the process, however I think we should make the change as it makes it easier to reason about.
|
||
Updated•5 years ago
|
Whiteboard: [domsecurity-active]
|
||
Updated•5 years ago
|
Blocks: rm-docshell-tree-item
|
||
Updated•5 years ago
|
Fission Milestone: --- → M5
Priority: P1 → P2
|
|
||
Updated•5 years ago
|
Fission Milestone: M5 → M4
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3804bb2592c
Fix IsFrame check to work in fission. r=ckerschb,nika
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•