Closed Bug 1585593 Opened 5 years ago Closed 5 years ago

[meta] Enable Fission for Raptor

Categories

(Testing :: Raptor, task, P1)

Version 3
task

Tracking

(Fission Milestone:M6, firefox73 fixed)

RESOLVED FIXED
mozilla73
Fission Milestone M6
Tracking Status
firefox73 --- fixed

People

(Reporter: davehunt, Assigned: marauder)

References

Details

(Keywords: meta)

Attachments

(1 file)

This is a tracking bug for getting the Raptor tests in CI with Fission enabled.

Component: Talos → Raptor
Type: enhancement → task
Assignee: nobody → marian.raiciof
Status: NEW → ASSIGNED

Hey Marian any updates on this issue please? I'm going to set it as P2 as it's been inactive for awhile but feel free to re-set to P1 when you pick it up again when you're back, thanks!

Flags: needinfo?(marian.raiciof)
Priority: P1 → P2
Blocks: 1594631

Hi Robert,

I think the patch is ready to land, but let's wait for the last push to try to finish:
https://phabricator.services.mozilla.com/D48316#1598342

The OS X jobs are looking good - i checked the logs and enable_fission argument is acting as expected for fission and non-fission jobs.
(Still waiting for other platforms to finish)

The only failures at the moment of writing this are related to https://bugzilla.mozilla.org/show_bug.cgi?id=1595350
failing to download the target.apk, but i don't think that my changes caused that.

Flags: needinfo?(marian.raiciof)
Priority: P2 → P1

Hey Marian, what is the status of this issue? Thanks!

Flags: needinfo?(marian.raiciof)

Hey Robert,
:ahal requested new changes and i'm testing these at the moment.
I'm waiting for two try jobs to finish and then i'll talk to ahal about my findings.
Thanks!

Hey Andrew,
I need your opinion on this https://phabricator.services.mozilla.com/D48316#1639461
Thanks!

Flags: needinfo?(marian.raiciof) → needinfo?(ahal)

Np, answered!

Flags: needinfo?(ahal)

Will this be landing soon? We could use baselines for fission in raptor. Thanks!

Flags: needinfo?(marian.raiciof)

Hey Andrew,
Let me know if i can land the patch considering these comments:
https://phabricator.services.mozilla.com/D48316#1686796
Thanks!

Flags: needinfo?(marian.raiciof) → needinfo?(ahal)
Pushed by mraiciof@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8aa294ef7cc2 Enable Fission for Raptor r=perftest-reviewers,rwood,stephendonner,sparky,ahal

Andrew, I decided to land this patch based on your previous review and if it's required to remove those if conditions i will create a follow-up bug.
Thanks!

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Fission Milestone: --- → M6
Flags: needinfo?(ahal)
See Also: → 1563224
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: