1585677 - [mozproxy] Use mozbuild's tooltool in mozproxy

Status: NEW

(Testing :: Mozbase, enhancement, P2)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Mozproxy's utils.py is currently using a subprocess for teching files and we want to replace it with mozbuild's fetch_files.

Comment 1

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Tarek, maybe we could change the purpose of this bug to use tooltool canonical.

Comment 2

[Tarek Ziadé (:tarek)]

I think step 1 is to have the tooltool on github vendored in m-c, and then we can use it here. So I would sync with Ben to see when we want to go ahead and add it in our vendored libs in /python

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Tarek Ziadé (:tarek) from comment #2)

I think step 1 is to have the tooltool on github vendored in m-c, and then we can use it here. So I would sync with Ben to see when we want to go ahead and add it in our vendored libs in /python

We already have it in /python, actually: https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/action/tooltool.py

Does that work for this case?

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

As I understood, the purpose of this was to avoid having n hardcopies of it, but to import it from one single place wherever we want to use it. I presume tarek is talking about adding it as dependency. Am I right, tarek?

Comment 5

[Tarek Ziadé (:tarek)]

https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/action/tooltool.py is not mozilla-tooltool-client , I was talking about having a vendored version of https://github.com/mozilla-releng/tooltool/blob/master/client/setup.py

so we don't rely on a copy that is somewhere in another project, but use a "mozilla-tooltool-client " release.

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Tarek Ziadé (:tarek) from comment #5)

https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/action/tooltool.py is not mozilla-tooltool-client , I was talking about having a vendored version of https://github.com/mozilla-releng/tooltool/blob/master/client/setup.py

so we don't rely on a copy that is somewhere in another project, but use a "mozilla-tooltool-client " release.

At the moment, copying tooltool.py is the supported way to vendor :), which is what the linked version is (at least, it's supposed to be). I want to change that later, but it's where we are now.

I wouldn't be opposed to an additional copy in the tree in https://searchfox.org/mozilla-central/source/third_party/python as a more officially vendored copy, if that's what you mean though.

Comment 7

[Tarek Ziadé (:tarek)]

At the moment, copying tooltool.py is the supported way to vendor

ok. if we do this, can we at least change the version number that is in tooltool.py ?

I wouldn't be opposed to an additional copy in the tree in https://searchfox.org/mozilla-central/source/third_party/python as a more officially vendored copy, if that's what you mean though.

that sounds good. my goal is mostly to reduce the number of occurences of tooltool.py in mozilla-central to a single one.
and maybe change the documentation that says it should be copied around, and propose to use that canonical version everywhere.

Comment 8

[Tarek Ziadé (:tarek)]

https://github.com/mozilla-releng/tooltool/issues/31

Comment 9

[[e-mail] (:bhearsum)]

(In reply to Tarek Ziadé (:tarek) from comment #8)

https://github.com/mozilla-releng/tooltool/issues/31

We closed this a few weeks ago.