1585686 - UnicodeEncodeError: 'ascii' codec can't encode character '\u2716' in position 9: ordinal not in range(128)

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ed Lee :Mardak]

Stylish is trying to print ✖ 0 problems (0 errors, 0 warnings) (the first character is '\u2716')

Error running mach:

    ['lint', 'browser/components/newtab']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

UnicodeEncodeError: 'ascii' codec can't encode character '\u2716' in position 9: ordinal not in range(128)

  File "/mozilla-central/tools/lint/mach_commands.py", line 80, in lint
    return cli.run(*runargs, **lintargs)
  File "/mozilla-central/python/mozlint/mozlint/cli.py", line 217, in run
    print(out, file=output_file)

https://searchfox.org/mozilla-central/rev/f372e8a46ef7659ef61be9938ec2a3ea34d343c6/python/mozlint/mozlint/cli.py#215-216

            output_file = open(path, 'w') if path else sys.stdout
            print(out, file=output_file)

I think it's trying to print to stdout… ?

Comment 1

[Ed Lee :Mardak]

andreio noticed that previously with python2, our taskcluster linux output showed ? 0 problems (0 errors, 0 warnings) so perhaps python2 automatically converted the non-ascii character to "?" while python3 throws an error instead.

Comment 2

[Andrew Halberstadt [:ahal]]

Hm, I'm not really sure why this is happening. Does setting PYTHONIOENCODING=utf-8 fix it? I suspect this might be an issue with your environment's locale/terminal encoding. Though if we can fix this for people we definitely should.

Comment 3

[Andrei Oprea [:andreio]]

Yes this seems to be an issue with the environment. The fix in this case was to:

export LC_ALL=C.UTF-8

Comment 4

[Ed Lee :Mardak]

https://github.com/mozilla/activity-stream/commit/150022b56a670a024f8deab9628b3644f01abd6c

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1585686 - [mozlint] Avoid UnicodeEncodeError for users who have an 'ascii' locale

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b995dbfa4d87
[mozlint] Avoid UnicodeEncodeError for users who have an 'ascii' locale r=gbrown

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b995dbfa4d87

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/be0251572777